Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize tests on closing and hiding the general forum topic #3460

Merged
merged 3 commits into from Jan 2, 2023
Merged

Stabilize tests on closing and hiding the general forum topic #3460

merged 3 commits into from Jan 2, 2023

Conversation

Bibo-Joshi
Copy link
Member

Let's hope this works :)

harshil21
harshil21 reviewed Jan 2, 2023
View reviewed changes
tests/test_forum.py Outdated Show resolved Hide resolved
tests/test_forum.py Show resolved Hide resolved
harshil21
harshil21 approved these changes Jan 2, 2023
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this still doesn't work, maybe adding an asyncio sleep next time would work?

@Bibo-Joshi Bibo-Joshi merged commit d1159cd into master Jan 2, 2023
@Bibo-Joshi Bibo-Joshi deleted the stable-forum-tests branch January 2, 2023 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 approved these changes

@lemontree210 lemontree210 lemontree210 approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bibo-Joshi @harshil21 @lemontree210