New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the missing notes about telegram.ext.JobQueue #3600
Merged
Bibo-Joshi
merged 4 commits into
python-telegram-bot:doc-fixes
from
beiluonever:patch-1
Mar 19, 2023
Merged
fix the missing notes about telegram.ext.JobQueue #3600
Bibo-Joshi
merged 4 commits into
python-telegram-bot:doc-fixes
from
beiluonever:patch-1
Mar 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if not use `pip install python-telegram-bot[job-queue]` to install PTB, will get `AttributeError: 'NoneType' object has no attribute 'get_jobs_by_name'` error.
Bibo-Joshi
requested changes
Mar 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for finding this mistake in out docs! Let's align the change with the other examples :)
thanks Bibo suggestions Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
already applied suggestions, thanks . |
Bibo-Joshi
merged commit Mar 19, 2023
b08116a
into
python-telegram-bot:doc-fixes
1 of 2 checks passed
Many thanks again :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if not use
pip install python-telegram-bot[job-queue]
to install PTB, will getAttributeError: 'NoneType' object has no attribute 'get_jobs_by_name'
error in this example.Checklist for PRs
.. versionadded:: version
,.. versionchanged:: version
or.. deprecated:: version
to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)AUTHORS.rst
(optional)__all__
sIf the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrs
and corresponding documentation__init__
acceptsapi_kwargs
as kw-onlyAdded new shortcuts:
Chat
&User
for all methods that acceptchat/user_id
Message
for all methods that acceptchat_id
andmessage_id
Message
shortcuts: Addedquote
argument if methods acceptsreply_to_message_id
CallbackQuery
for all methods that accept eitherchat_id
andmessage_id
orinline_message_id
If relevant:
telegram.constants
and shortcuts to them as class variablesMessage.effective_attachment
ConversationHandler
_extbot.py
bot_methods.rst
README.rst
andREADME_RAW.rst
(including the badge), as well astelegram.constants.BOT_API_VERSION_INFO
tg.ext.Bot
for new methods that either accept areply_markup
in some form or have a return type that is/containstelegram.Message