Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the missing notes about telegram.ext.JobQueue #3600

Merged
merged 4 commits into from Mar 19, 2023
Merged

fix the missing notes about telegram.ext.JobQueue #3600

merged 4 commits into from Mar 19, 2023

Conversation

beiluonever
Copy link
Contributor

if not use pip install python-telegram-bot[job-queue] to install PTB, will get AttributeError: 'NoneType' object has no attribute 'get_jobs_by_name' error in this example.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as kw-only
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard coded number and strings
    • Add new message types to Message.effective_attachment
    • Added new handlers for new update types
      • Add the handlers to the warning loop in the ConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

if not use `pip install python-telegram-bot[job-queue]` to install PTB, will get `AttributeError: 'NoneType' object has no attribute 'get_jobs_by_name'` error.
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for finding this mistake in out docs! Let's align the change with the other examples :)

examples/timerbot.py Outdated Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi changed the base branch from master to doc-fixes March 19, 2023 10:02
github-actions[bot]

This comment was marked as resolved.

github-actions[bot]

This comment was marked as resolved.

Bibo-Joshi and others added 2 commits March 19, 2023 11:02
thanks Bibo suggestions

Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
@beiluonever
Copy link
Contributor Author

Hi, thanks for finding this mistake in out docs! Let's align the change with the other examples :)

already applied suggestions, thanks .

@Bibo-Joshi Bibo-Joshi merged commit b08116a into python-telegram-bot:doc-fixes Mar 19, 2023
1 of 2 checks passed
@Bibo-Joshi
Copy link
Member

Many thanks again :)

Bibo-Joshi added a commit that referenced this pull request Mar 25, 2023
Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
Co-authored-by: poolitzer <github@poolitzer.eu>
Co-authored-by: Louis Wang <beiluonever@users.noreply.github.com>
@harshil21 harshil21 added this to the v20.2 milestone Mar 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants