Customized concurrent handling #3654

clot27 · 2023-04-09T17:35:50Z

Closes #3509 when done.

Checklist for PRs

Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
Created new or adapted existing unit tests
Documented code changes according to the CSI standard
~~[ ] Added myself alphabetically to AUTHORS.rst (optional)~~
Added new classes & modules to the docs and all suitable __all__ s

…am-bot into customized-concurrent-handling

Bibo-Joshi

Thanks for the nice PR @clot27 !
IMO it covers the contents of #3509 pretty well and the overvall logic looks good :) I left some comments already though I'll ofc do a proper review again once it's out of draft status .

docs/source/telegram.ext.BaseProcessor.rst

telegram/ext/_application.py

telegram/ext/_applicationbuilder.py

…am-bot into customized-concurrent-handling

harshil21

initial review. Will review again after tests are added, implementation looks ok to me

docs/source/telegram.ext.BaseProcessor.rst

telegram/ext/__init__.py

telegram/ext/_application.py

telegram/ext/_applicationbuilder.py

telegram/ext/_application.py

telegram/ext/_applicationbuilder.py

Bibo-Joshi

Thanks for the updates! This will come out great :) I left a bunch of new comments, but nothing major IMO.

telegram/ext/_application.py

telegram/ext/_applicationbuilder.py

telegram/ext/_baseupdateprocessor.py

telegram/ext/_applicationbuilder.py

…am-bot into customized-concurrent-handling

telegram/ext/_baseupdateprocessor.py

harshil21

more comments. But looking much more refined now 👍🏽

telegram/ext/__init__.py

telegram/ext/_application.py

telegram/ext/_baseupdateprocessor.py

tests/ext/test_application.py

telegram/ext/_application.py

telegram/ext/_baseupdateprocessor.py

tests/ext/test_application.py

tests/ext/test_applicationbuilder.py

tests/ext/test_baseupdateprocessor.py

Bibo-Joshi

Thanks for the new updates! I left smaller comments :) Also the docs build is failing …

Regarding the unit tests on the update processors: TBH I don't see them going in a right direction and I'm not sure how I can explain better what should be covered. I will try and write some tests myself, but please do feel free to ask anything about that if you have questions :)

telegram/ext/_application.py

tests/ext/test_application.py

tests/ext/test_applicationbuilder.py

telegram/ext/_baseupdateprocessor.py

Bibo-Joshi

LGTM :) @harshil21 do you have anything to add?

After merge, the dev-wiki should be updated to

elaborate on the new processor on the page on concurrency
mention the BaseUpdateProcessor on the architecture page. This would be a good chance to convert the graphic to a mermaid diagram

harshil21

final review. Looks much more refined and ready. Good job @clot27. Just some tiny errors caught:

telegram/ext/_application.py

telegram/ext/_applicationbuilder.py

telegram/ext/_baseupdateprocessor.py

tests/ext/test_application.py

docs/source/telegram.ext.simpleupdateprocessor.rst

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

harshil21

nice upgrade!

Bibo-Joshi · 2023-06-02T16:17:40Z

Big thanks to @clot27 for your work and also your patience! 👏

Aditya added 2 commits April 9, 2023 22:57

add customized concurrent handling

46f5355

Merge branch 'master' of github.com:python-telegram-bot/python-telegr…

e3245c1

…am-bot into customized-concurrent-handling

clot27 marked this pull request as draft April 9, 2023 17:37

Bibo-Joshi reviewed Apr 10, 2023

View reviewed changes

Merge branch 'master' of github.com:python-telegram-bot/python-telegr…

1ccfeae

…am-bot into customized-concurrent-handling

harshil21 requested changes Apr 11, 2023

View reviewed changes

Aditya added 4 commits April 12, 2023 00:55

add some requested changes

a8bf427

add docstrings

ecf2721

some more improvements

f9d8f30

exclude making new tasks when concurrent_updates is 0

ab95f79

Bibo-Joshi requested changes Apr 17, 2023

View reviewed changes

Bibo-Joshi reviewed Apr 17, 2023

View reviewed changes

telegram/ext/_applicationbuilder.py Outdated Show resolved Hide resolved

telegram/ext/_applicationbuilder.py Outdated Show resolved Hide resolved

Aditya added 2 commits April 19, 2023 20:14

requested changes

2be64f2

Merge branch 'master' of github.com:python-telegram-bot/python-telegr…

249caa4

…am-bot into customized-concurrent-handling

Bibo-Joshi reviewed Apr 23, 2023

View reviewed changes

telegram/ext/_baseupdateprocessor.py Outdated Show resolved Hide resolved

harshil21 reviewed Apr 24, 2023

View reviewed changes

Aditya added 3 commits April 25, 2023 16:44

add tests and requested changes

88d11ba

fix tests and docstrings

99e556e

add slots

19d47fe

clot27 marked this pull request as ready for review April 25, 2023 15:01

clot27 requested review from Bibo-Joshi and harshil21 April 25, 2023 15:01

extend test coverage

c922b9c

harshil21 reviewed Apr 27, 2023

View reviewed changes

tests/ext/test_application.py Outdated Show resolved Hide resolved

Aditya and others added 2 commits May 2, 2023 20:11

fix tests

5f4ab1d

Merge branch 'master' into customized-concurrent-handling

f450e20

Bibo-Joshi reviewed May 3, 2023

View reviewed changes

clot27 and others added 3 commits May 7, 2023 17:20

Merge branch 'master' into customized-concurrent-handling

a2bf83d

add tests and some requested changes

3c8f4e5

fix tests

9c0fa9a

really fix them this time

5b7c4a0

Bibo-Joshi added enhancement needs wiki update 📖 PRs which warrants a wiki update after merge/release labels May 17, 2023

Bibo-Joshi requested changes May 17, 2023

View reviewed changes

telegram/ext/_application.py Outdated Show resolved Hide resolved

tests/ext/test_application.py Outdated Show resolved Hide resolved

tests/ext/test_application.py Outdated Show resolved Hide resolved

tests/ext/test_applicationbuilder.py Show resolved Hide resolved

Bibo-Joshi and others added 5 commits May 17, 2023 22:29

Pimp my tests :)

f3a6585

Merge branch 'master' into customized-concurrent-handling

7a30965

Fix failing tests

d535c46

fix docs

bb7caf8

add test for SUP with 'is'

b60c119

Bibo-Joshi reviewed May 19, 2023

View reviewed changes

telegram/ext/_baseupdateprocessor.py Outdated Show resolved Hide resolved

Aditya and others added 4 commits May 20, 2023 08:12

add final requested changes

39b1adb

Fine tune tests

6cc2102

Add some versioning directives

764a5d0

Merge branch 'master' into customized-concurrent-handling

59db8d3

Bibo-Joshi approved these changes May 20, 2023

View reviewed changes

typo

9aeeb08

harshil21 reviewed May 29, 2023

View reviewed changes

Aditya added 2 commits May 30, 2023 19:00

address final review

168eac4

fix pre-commit

550431c

harshil21 reviewed Jun 2, 2023

View reviewed changes

docs/source/telegram.ext.simpleupdateprocessor.rst Outdated Show resolved Hide resolved

clot27 and others added 2 commits June 2, 2023 16:23

Update docs/source/telegram.ext.simpleupdateprocessor.rst

d03f81e

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>

Merge branch 'master' into customized-concurrent-handling

429c023

harshil21 approved these changes Jun 2, 2023

View reviewed changes

Bibo-Joshi merged commit bf54599 into master Jun 2, 2023
24 checks passed

Bibo-Joshi deleted the customized-concurrent-handling branch June 2, 2023 16:17

Bibo-Joshi mentioned this pull request Jun 2, 2023

[FEATURE] Automatic dismiss repeated callbackquery updates #2539

Closed

github-actions bot locked and limited conversation to collaborators Jun 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Customized concurrent handling #3654

Customized concurrent handling #3654

clot27 commented Apr 9, 2023 •

edited by Bibo-Joshi

Bibo-Joshi left a comment

harshil21 left a comment

Bibo-Joshi left a comment

harshil21 left a comment

Bibo-Joshi left a comment

Bibo-Joshi left a comment

harshil21 left a comment

harshil21 left a comment

Bibo-Joshi commented Jun 2, 2023

Customized concurrent handling #3654

Customized concurrent handling #3654

Conversation

clot27 commented Apr 9, 2023 • edited by Bibo-Joshi

Checklist for PRs

Bibo-Joshi left a comment

Choose a reason for hiding this comment

harshil21 left a comment

Choose a reason for hiding this comment

Bibo-Joshi left a comment

Choose a reason for hiding this comment

harshil21 left a comment

Choose a reason for hiding this comment

Bibo-Joshi left a comment

Choose a reason for hiding this comment

Bibo-Joshi left a comment

Choose a reason for hiding this comment

harshil21 left a comment

Choose a reason for hiding this comment

harshil21 left a comment

Choose a reason for hiding this comment

Bibo-Joshi commented Jun 2, 2023

clot27 commented Apr 9, 2023 •

edited by Bibo-Joshi