New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect and inconsistent timeout types #3709
Fix incorrect and inconsistent timeout types #3709
Conversation
Hi. I'm not quite sure what this PR is aiming at. Would you mind explaining where you see inconsistency in the types? IISC we use |
Yes, sure, sorry for not explaining it from the start. So, knowing that the official
So, the bottom line is that all of them should be |
Let me know if you agree, and I'll rebase and fix the conflicts 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation and the catch! Yes, I would like to have the merged, then :) Would you mind resolving the merge conflicts?
All done 😁 |
d295098
to
ed924ff
Compare
Than you for the contribution! |
And thank you for merging! |
No description provided.