Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-Update Changed Version in Other Files After Dependabot PRs #3716

Merged
merged 4 commits into from
May 31, 2023

Conversation

Bibo-Joshi
Copy link
Member

This new workflow automatically copies versions changed by depandabot to the pre-commit config, the readme and any other file where the version might appear. It's a mit naive, b/c it really just searches for exact matches of the version number, but I guess the cases were we have that exact version number appear elsewhere in the repo are seldom enough. Plus, we can review.

Live examples of this workflow can be seen at https://github.com/Bibo-Joshi/actions-tests/pulls (where you can also see that I got this working almost immediately 馃珷)

@Bibo-Joshi Bibo-Joshi added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels May 20, 2023
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label May 20, 2023
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow nice! Can't we tell it which files to look for though, so error rate can become 0%

@Bibo-Joshi
Copy link
Member Author

That was also my inital thought, but that might lead to false negatives. As those can't be seen in a PR diff, I decided that false positives might be the better.

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright then, LGTM

@Bibo-Joshi Bibo-Joshi merged commit 4c8d733 into master May 31, 2023
24 checks passed
@Bibo-Joshi Bibo-Joshi deleted the post-process-depeandabot-prs branch May 31, 2023 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants