Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add walrus operator wherever possible #3749

Merged

Conversation

thefunkycat
Copy link
Contributor

@thefunkycat thefunkycat commented Jun 6, 2023

Solves #3734

I have tried to add the walrus operator wherever possible.

I went through most files.
There were a couple more instances I found where I could have added it, but it was unnecessary and would not have necessarily improved readability or code quality.

I was more lenient when it came to adding the walrus operator to tests

@thefunkycat
Copy link
Contributor Author

@Bibo-Joshi @clot27 is there a reason the test_send_animation_url_file() and test_send_all_args() are failing? is this me? or is this a pre existing issue

@Bibo-Joshi
Copy link
Member

Thanks for the PR! The tests are failing on some other PRs since yesterday, too. Seems like something changed in the TG servers. We'll have to investigate.

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests seem to have recovered. Now only TestInlineQueryHandler.test_context_pattern is failing. I guess that's due to your changes though TBH I don't really see a flaw in those … Would you mind double check ing that?

@thefunkycat
Copy link
Contributor Author

thefunkycat commented Jun 8, 2023

@Bibo-Joshi should be fixed now :)

Edit: oof the tests still fail but this is related to submitting the test coverage, all the tests pass. so not the code.

@Bibo-Joshi Bibo-Joshi merged commit a1c2fe7 into python-telegram-bot:drop-py-37 Jun 8, 2023
18 of 19 checks passed
@Bibo-Joshi
Copy link
Member

Thank you very much for the nice contribution :)

@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants