Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more ruff rules #3763

Merged
merged 6 commits into from Jun 29, 2023
Merged

Add some more ruff rules #3763

merged 6 commits into from Jun 29, 2023

Conversation

@harshil21 harshil21 added this to the v20.4 milestone Jun 18, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meta question: I guess you kept track of the changelog and added the new rules manually?

telegram/ext/_aioratelimiter.py Show resolved Hide resolved
tests/ext/test_jobqueue.py Show resolved Hide resolved
@harshil21
Copy link
Member Author

Meta question: I guess you kept track of the changelog and added the new rules manually?

at first no, I went through the whole list again, but with the newer versions released since this PR, yes I tracked the changelog

@Bibo-Joshi
Copy link
Member

Meta question: I guess you kept track of the changelog and added the new rules manually?

at first no, I went through the whole list again, but with the newer versions released since this PR, yes I tracked the changelog

Okay. I'm wondering if we can automate that a bit … or at least do that manually on dependabot PRs …

'assert job==job
@harshil21
Copy link
Member Author

Okay. I'm wondering if we can automate that a bit … or at least do that manually on dependabot PRs …

I'm okay with checking manually on dependabot PRs for now

Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) let's wait for the master branch to work again before merging, though …

@Bibo-Joshi Bibo-Joshi merged commit 58b89cf into master Jun 29, 2023
25 checks passed
@Bibo-Joshi Bibo-Joshi deleted the more-ruff-rules branch June 29, 2023 09:38
clot27 pushed a commit that referenced this pull request Jul 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants