New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some more ruff
rules
#3763
Add some more ruff
rules
#3763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited the (optional) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the additional dependencies for the hooks in sync with the requirements :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meta question: I guess you kept track of the changelog and added the new rules manually?
at first no, I went through the whole list again, but with the newer versions released since this PR, yes I tracked the changelog |
Okay. I'm wondering if we can automate that a bit … or at least do that manually on dependabot PRs … |
'assert job==job
I'm okay with checking manually on dependabot PRs for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) let's wait for the master branch to work again before merging, though …
Adds: