Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Test Artifacts Automatically #3777

Merged
merged 9 commits into from
Jul 3, 2023
Merged

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Jun 26, 2023

Makes sure that some artifacts that currently always clutter my root directory are properly removed.

Already makes use of the missing_ok parameter in anticipation of #3728 and should hence be merged after that.

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we use the tmp_path pytest fixture?

@Bibo-Joshi
Copy link
Member Author

can't we use the tmp_path pytest fixture?

Nice idea! writing to those files gives me permisison denied errors currently. Will have a look if I can fix that.

# Conflicts:
#	tests/_files/test_animation.py
#	tests/_files/test_audio.py
#	tests/_files/test_chatphoto.py
#	tests/_files/test_document.py
#	tests/_files/test_photo.py
#	tests/_files/test_sticker.py
#	tests/_files/test_video.py
#	tests/_files/test_videonote.py
#	tests/_files/test_voice.py
@Bibo-Joshi Bibo-Joshi merged commit 5534ddf into master Jul 3, 2023
20 checks passed
@Bibo-Joshi Bibo-Joshi deleted the delete-test-artifacts branch July 3, 2023 08:06
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants