Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document more about proxy_url and get_updates_proxy_url #3816

Merged
merged 3 commits into from Aug 2, 2023

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jul 27, 2023

No description provided.

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I would be okay with adding this 'see also' note in all the (get_updates_)* methods in AppBuilder. What say others?

telegram/ext/_applicationbuilder.py Outdated Show resolved Hide resolved
telegram/ext/_applicationbuilder.py Outdated Show resolved Hide resolved
@harshil21 harshil21 changed the base branch from master to doc-fixes July 27, 2023 20:16
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-Joshi
Copy link
Member

I would prefer to just add a .. seealso:: get_updates_proxy_url (+ vice versa + for all other request related methods that have two variants)

Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Would you mind also adding similar changes to the other get_updates_* methods and their counterparts?

@trim21
Copy link
Contributor Author

trim21 commented Aug 2, 2023

Thanks for the updates! Would you mind also adding similar changes to the other get_updates_* methods and their counterparts?

I do mind...

@Bibo-Joshi Bibo-Joshi merged commit d207388 into python-telegram-bot:doc-fixes Aug 2, 2023
4 of 5 checks passed
@Bibo-Joshi
Copy link
Member

Fair enough, thanks for the contribution in any case!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants