API 6.8

[harshil21]

Checklist

• Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION or .. deprecated:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
• Created new or adapted existing unit tests
• Documented code changes according to the CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
• Added myself alphabetically to AUTHORS.rst (optional)
• Added new classes & modules to the docs and all suitable __all__ s
• Checked the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior
• Create PR to remove functionality deprecated in API 6.7 #3673

If the PR contains API changes (otherwise, you can ignore this passage)

• Checked the Bot API specific sections of the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_

• New classes:

  • Added self._id_attrs and corresponding documentation
  • __init__ accepts api_kwargs as kw-only

• Added new shortcuts:

  • In :class:~telegram.Chat & :class:~telegram.User for all methods that accept chat/user_id
  • In :class:~telegram.Message for all methods that accept chat_id and message_id
  • For new :class:~telegram.Message shortcuts: Added quote argument if methods accepts reply_to_message_id
  • In :class:~telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

• If relevant:

  • Added new constants at :mod:telegram.constants and shortcuts to them as class variables
  • Link new and existing constants in docstrings instead of hard-coded numbers and strings
  • Add new message types to :attr:telegram.Message.effective_attachment
  • Added new handlers for new update types
  • Add the handlers to the warning loop in the :class:~telegram.ext.ConversationHandler
  • Added new filters for new message (sub)types
  • Added or updated documentation for the changed class(es) and/or method(s)
  • Added the new method(s) to _extbot.py
  • Added or updated bot_methods.rst
  • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION_INFO
  • Added logic for arbitrary callback data in :class:telegram.ext.ExtBot for new methods that either accept a reply_markup in some form or have a return type that is/contains :class:~telegram.Message

[github-actions]

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

[Bibo-Joshi]

Thanks for the PR! I've left a few comments. IISC the only mismatch with the Bot API left is the arguments of PollAnswer becoming optional.

In addition to adding the new functionality, we must also remove all deprecations & backward compatibility layers we introduced for API 6.7, in accordance to our stability policy. This should be done in a separate PR IMO. Still, I'm adding it to the checklist for completeness.

[Bibo-Joshi]

Thanks for the updates! :)

[Bibo-Joshi]

Found one more item in the checklist - otherwise I'm happy :)

[Bibo-Joshi]

LGTM, then :) @clot27 @harshil21 do you have anything to add? @lemontree210 @Poolitzer do you want to review as well?

[harshil21]

LGTM

[Poolitzer]

And we should change the int attribute to datetime as well hmmm.

Do we have other empty classes trigger attachment? Because this feels wrong to me tbh.

[Poolitzer]

Nice backwards compatibility change

[Bibo-Joshi]

@Poolitzer Uff how did we miss that. Yes the expiration date need to be converted to datetime.