Verify type hints for Bot method & class parameters #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
suggestions for optimizations / a different approach welcome btw |
few other minor changes
Breaking change: PassportFile.file_date now returns a datetime instead of integer
harshil21
force-pushed
the
improve-test-official
branch
from
2b8397b
to
02b5060
Compare
harshil21
changed the title
Bibo-Joshi
reviewed
Sep 4, 2023
There was a problem hiding this comment.
Pfew, that is quite some code 🤯 I went through it once and left a bunch of comments, but I probably didn't get everything :D
I feel like as a follow-up of this PR, a refactoring of test_official into multiple modules is in order. I'll create an issue for that.
harshil21
commented
Sep 4, 2023
harshil21
commented
Sep 5, 2023
Also rearrange 2 tests
Also don't collect test_official on py < 3.10
Bibo-Joshi
approved these changes
Sep 10, 2023
Poolitzer
approved these changes
Sep 11, 2023
also remove print statements
|
Deepsource failure is unrelated. Merging once other tests pass |
|
Awesome addition! thanks a lot :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands
test_officialby verifying that the type hints in our lib is same as TG API's.Also changes type hint of
user_idin bot methods fromint | strto justintas specified by the API.The change is breaking becauseNo longer breaking.PassportFile.file_datenow accepts a datetime only, and itsde_jsonnow converts int -> datetime.Tests pass locally, seem to be failing here mysteriously
After review, before merge: