Add JobQueue.scheduler_configuration and add corresponding warnings
#3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dmitry K <58207913+lemontree210@users.noreply.github.com>
Co-authored-by: Dmitry K <58207913+lemontree210@users.noreply.github.com>
|
Please make sure you delete me from authors before merging, otherwise I'll be known for co-authoring a commit to master just because I changed one letter :) |
harshil21
reviewed
Oct 16, 2023
|
macos py3.12 test consistently failing, but the errors aren't exactly related to this PR? |
|
Mh, codecov doesn't complain in their UI and I'm also pretty certain that the tests cover everything. Maybe the annotations just stuck from the initial runs … TBH I don't recall why the macos tests failed. Might have been due to codecov upload failure. I'm rerunning. |
harshil21
approved these changes
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for closing #3837
Makes the config values used by
JobQueuepublically accessible so that users can use them in addition to their custom values. Also adds warnigs that explain what this is about.@rejedai, would you mind also having a look at this, given that you reported the issue?
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSIONor.. deprecated:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__Added myself alphabetically toAUTHORS.rst(optional)Added new classes & modules to the docs and all suitable__all__sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behaviorcloses #3837