Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApplicationBuilder.(get_updates_)socket_options #3943

Merged
merged 7 commits into from Oct 31, 2023

Conversation

Bibo-Joshi
Copy link
Member

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION or .. deprecated:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

* Follow up for #3935
* Also adds tests that make sure that `ApplicationBuilder` has all necessary methods
Copy link
Member

@lemontree210 lemontree210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did look through the code and it looks fine but I don't feel like I'm qualified enough to judge :)

Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code in general looks good to me.

tests/ext/test_applicationbuilder.py Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi merged commit 616b0b5 into master Oct 31, 2023
23 checks passed
@Bibo-Joshi Bibo-Joshi deleted the socket-opits-appbuilder branch October 31, 2023 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants