New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust read_timeout
behavior for get_updates
#3963
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bibo-Joshi
requested review from
Poolitzer,
tsnoam and
harshil21
and removed request for
tsnoam
November 6, 2023 19:57
Poolitzer
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
harshil21
requested changes
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
harshil21
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
# Conflicts: # tests/request/test_request.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ready, closes #3893
Mostly as outlined in that issue. Also includes the suggestions from #3959
I decided to already change the default for
read_timeout
toDEFAULT_NONE
, i.e. consider this a non-breaking change, becauseApplicationBuilder.get_updates_read_timeout
,Application.run_polling
,Bot.get_updates
,BaseRequest.do_request
, it is not directly clear which value overrides which other value, such that IMO there is no completely clear expected behavior IMOBaseRequest
nothing changesToDo:
write_timeout
Handling for Media Methods #3952.. versionadded:: NEXT.VERSION
,.. versionchanged:: NEXT.VERSION
or.. deprecated:: NEXT.VERSION
to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)read_timeout
ofBot.get_updates
- doing that after Improvewrite_timeout
Handling for Media Methods #3952 is merged so that I don't have to change the logic of the insertion twiceCSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>
__AUTHORS.rst
(optional)[ ] Added new classes & modules to the docs and all suitable__all__
sStability Policy <https://docs.python-telegram-bot.org/stability_policy.html>
_ in case of deprecations or changes to documented behavior