New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and overhaul test_official
#4087
Conversation
test official
test_official
I scrolled through the changes and didn't see anything that made me want to leave a comment. IISC much of the changes are reorderings, additional comments & extraction of methods, so I've seen most of the code before as well. - Which is ofc not meant to downplay the work you've put into this PR and the gain in maintenability this brings! You added the do-not-merge label. Do you want to merge after API 7.0? |
yeah there are just tiny changes here and there to make it easier to maintain, but the code is largely the same.
Yes, and that would also give me time to see if I can simplify / improve the |
Latest commits significantly improve As a result of simplification, it also found incorrect type hints which went undetected before. There was also further "modularization" making the code easier to follow. |
3ecde3d
to
69fb8e6
Compare
This was achieved by resolving ForwardRefs and changing the method of how type annotations are compared with the official API
69fb8e6
to
c55e5e2
Compare
Sorry again for the merge mess-up and big kudos for the PR! |
Closes #3874
Features of the overhauled
test_official
:check_param_type
function. If you run pytest with--log-level=DEBUG
and that test fails, you'll see the logged statements.check_param_type
function. See Refactor and overhaultest_official
#4087 (comment) and f5704da 's commit message.If you see any more areas of improvement, feel free to mention it.