Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parameter media_write_timeout to HTTPXRequest and Method ApplicationBuilder.media_write_timeout #4120

Merged
merged 4 commits into from Feb 26, 2024
Merged

Add Parameter media_write_timeout to HTTPXRequest and Method ApplicationBuilder.media_write_timeout #4120

merged 4 commits into from Feb 26, 2024

Conversation

Bibo-Joshi
Copy link
Member

Last part of and closes #3864

harshil21
harshil21 requested changes Feb 25, 2024
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation looks good. found one place we can improve the documentation and a bug.

telegram/ext/_applicationbuilder.py Show resolved Hide resolved
telegram/request/_httpxrequest.py Show resolved Hide resolved
@Bibo-Joshi Bibo-Joshi merged commit 9c263fb into master Feb 26, 2024
23 of 24 checks passed
@Bibo-Joshi Bibo-Joshi deleted the media-write-timeout-argument branch February 26, 2024 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 approved these changes

@clot27 clot27 clot27 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review types of optional arguments in methods and classes
3 participants
@Bibo-Joshi @harshil21 @clot27