New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support passing socket directly #4161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left a few comments below.
Tests don't seem to be happy:
tests.ext.test_updater
collection failure
ImportError while importing test module '/home/runner/work/python-telegram-bot/python-telegram-bot/tests/ext/test_updater.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/importlib/init.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
tests/ext/test_updater.py:28: in <module>
from tornado.netutil import bind_unix_socket
E ModuleNotFoundError: No module named 'tornado'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) When tests pass & pool can confirm his local tests, we can merge
@Bibo-Joshi Can confirm now, works. |
1 similar comment
@Bibo-Joshi Can confirm now, works. |
This adds support to pass sockets instances instead of file paths.
Closes #4078