Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API 7.2 #4180

Merged
merged 32 commits into from Apr 12, 2024
Merged

API 7.2 #4180

merged 32 commits into from Apr 12, 2024

Conversation

harshil21
Copy link
Member

@harshil21 harshil21 commented Mar 31, 2024 •
edited by Bibo-Joshi

closes #4179. closes #4181

Checklist

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION or .. deprecated:: NEXT.VERSION to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard <https://standards.mousepawmedia.com/en/stable/csi.html>__
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy <https://docs.python-telegram-bot.org/stability_policy.html>_ in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of the Stability Policy

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as kw-only

  • Added new shortcuts:

    • In :class:~telegram.Chat & :class:~telegram.User for all methods that accept chat/user_id
    • In :class:~telegram.Message for all methods that accept chat_id and message_id
    • For new :class:~telegram.Message shortcuts: Added do_quote argument if methods accepts reply_to_message_id
    • In :class:~telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

  • If relevant:

    • Added new constants at :mod:telegram.constants and shortcuts to them as class variables
    • Link new and existing constants in docstrings instead of hard-coded numbers and strings
    • Add new message types to :attr:telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Add the handlers to the warning loop in the :class:~telegram.ext.ConversationHandler
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in :class:telegram.ext.ExtBot for new methods that either accept a reply_markup in some form or have a return type that is/contains :class:~telegram.Message

@harshil21 harshil21 added the API label Mar 31, 2024
github-actions[bot]
github-actions bot reviewed Mar 31, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@harshil21 harshil21 linked an issue Apr 1, 2024 that may be closed by this pull request
[BUG] StickerSet require parameters that API no longer sends #4181
Closed
harshil21 and others added 19 commits March 31, 2024 22:44
@harshil21
Add new parameters to Update along with the new method
badf3fc
@harshil21
forgot to add method to extbot
6bb22f4
@harshil21
Add new handlers and filters
1b33dfa
@harshil21
fix doc build and improve type completeness
dc3c1b9
@harshil21
Apply Sticker method and pack changes
3ff7a68
@harshil21
fix tests again
e942ebf
@mahdyar
Feat: add the field is_from_offline to the class Message (#4189)
dcb471e
@Bibo-Joshi
Merge branch 'master' into api-7.2
17b295a
@Bibo-Joshi
Revert "Temporarily Mark Tests with get_sticker_set as XFAIL due to…
6b6fcf5 
… API 7.2 Update (#4190)"

This reverts commit 7331fff.
@harshil21
Make test_drop_callback_data use NonchalantHttpxRequest to avoid floo…
c67f751 
…d errors
@harshil21
Add Birthdate class and field to Chat
9250017
@harshil21
Add replace_sticker_in_set method
a1f86c6
@harshil21
Add can_connect_to_business field
a9e0eda
@harshil21
Add personal_chat to Chat
3d513ec
@harshil21
Add filters.IS_FROM_OFFLINE
c350584
@harshil21
Update test_official
f927ad0
@harshil21
Improve test coverage
275fd33
@harshil21
Doc fix for the new handlers
b3becd6
@harshil21
change business_connection_id test target
9305a43
@harshil21 harshil21 mentioned this pull request Apr 4, 2024
Merged
Bibo-Joshi
Bibo-Joshi requested changes Apr 5, 2024
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a first review - my first contribution to this api update 😅

telegram/_birthdate.py Outdated Show resolved Hide resolved
telegram/_bot.py Show resolved Hide resolved
telegram/_business.py Outdated Show resolved Hide resolved
telegram/_business.py Outdated Show resolved Hide resolved
telegram/_files/sticker.py Outdated Show resolved Hide resolved
telegram/ext/filters.py Show resolved Hide resolved
telegram/ext/filters.py Show resolved Hide resolved
tests/ext/test_callbackcontext.py Show resolved Hide resolved
tests/test_bot.py Show resolved Hide resolved
tests/test_bot.py Outdated Show resolved Hide resolved
@aelkheir @harshil21
Business info (#4183)
bb9bdb4 
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
@Bibo-Joshi Bibo-Joshi mentioned this pull request Apr 7, 2024
Open
Bibo-Joshi
Bibo-Joshi requested changes Apr 7, 2024
View reviewed changes
telegram/_shared.py Outdated Show resolved Hide resolved
telegram/_shared.py Show resolved Hide resolved
telegram/_shared.py Show resolved Hide resolved
Bibo-Joshi and others added 2 commits April 7, 2024 11:31
@Bibo-Joshi
Merge branch 'master' into api-7.2
88bba66 
# Conflicts:
#	telegram/ext/filters.py
#	tests/test_constants.py
#	tests/test_official/exceptions.py
@harshil21
Review: remove business_connection_id from Message methods
91b1da6 
also doc fixes and other stuff
Bibo-Joshi
Bibo-Joshi reviewed Apr 7, 2024
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed new changes, found nothing to nitpick :) GH just wants me to leave a comment so that I can mark the changes as reviewed :D

Bibo-Joshi
Bibo-Joshi approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the changes one more time but nothing caught my eye. Thanks again for putting together this PR so quickly 👏

@Bibo-Joshi Bibo-Joshi merged commit 5fa4579 into master Apr 12, 2024
25 checks passed
@Bibo-Joshi Bibo-Joshi deleted the api-7.2 branch April 12, 2024 09:58
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] StickerSet require parameters that API no longer sends [Feature] API 7.2
5 participants
@harshil21 @Bibo-Joshi @mahdyar @aelkheir @clot27