Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download changed #459

Merged
merged 7 commits into from Dec 18, 2016
Merged

Download changed #459

merged 7 commits into from Dec 18, 2016

Conversation

OctoNezd
Copy link
Contributor

@OctoNezd OctoNezd commented Nov 6, 2016

Now accepts arg out, which accepts a file-like object

@OctoNezd
Copy link
Contributor Author

OctoNezd commented Nov 6, 2016

For some reason, all checks fail on send_contact. Btw, it doesnt get affceted by my changes.
(i mean travis-ci)

@OctoNezd
Copy link
Contributor Author

OctoNezd commented Nov 6, 2016

Tests on mine server says everything(except Botan) is fine

@lisitsky
Copy link
Contributor

lisitsky commented Nov 7, 2016

Travis says, it got HTTP Error 429 "Too many requests" from Telegram API during tests:

======================================================================
ERROR: test_send_contact (tests.test_bot.BotTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/tests/base.py", line 84, in newfunc
    rc = func(*args, **kwargs)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/tests/test_bot.py", line 353, in test_send_contact
    message = self._bot.send_contact(self._chat_id, phone, name, last)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/bot.py", line 124, in decorator
    result = func(self, *args, **kwargs)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/bot.py", line 150, in decorator
    result = self._request.post(url, data, timeout=kwargs.get('timeout'))
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/utils/request.py", line 205, in post
    **urlopen_kwargs)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/utils/request.py", line 156, in _request_wrapper
    raise NetworkError('{0} ({1})'.format(message, resp.status))
telegram.error.NetworkError: Too Many Requests: retry after 24518 (429)

I think it will be very hard to test, because such errors could emerge everywhere during repeating tests.

@jh0ker
Copy link
Member

jh0ker commented Dec 18, 2016

OK I fixed the pre-commit hooks, so I'll merge

@jh0ker jh0ker merged commit c3984e1 into python-telegram-bot:master Dec 18, 2016
@OctoNezd
Copy link
Contributor Author

yay

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants