New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download changed #459

Merged
merged 7 commits into from Dec 18, 2016

Conversation

Projects
None yet
3 participants
@OctoNezd
Contributor

OctoNezd commented Nov 6, 2016

Now accepts arg out, which accepts a file-like object

@OctoNezd

This comment has been minimized.

Show comment
Hide comment
@OctoNezd

OctoNezd Nov 6, 2016

Contributor

For some reason, all checks fail on send_contact. Btw, it doesnt get affceted by my changes.
(i mean travis-ci)

Contributor

OctoNezd commented Nov 6, 2016

For some reason, all checks fail on send_contact. Btw, it doesnt get affceted by my changes.
(i mean travis-ci)

@OctoNezd

This comment has been minimized.

Show comment
Hide comment
@OctoNezd

OctoNezd Nov 6, 2016

Contributor

Tests on mine server says everything(except Botan) is fine

Contributor

OctoNezd commented Nov 6, 2016

Tests on mine server says everything(except Botan) is fine

@lisitsky

This comment has been minimized.

Show comment
Hide comment
@lisitsky

lisitsky Nov 7, 2016

Contributor

Travis says, it got HTTP Error 429 "Too many requests" from Telegram API during tests:

======================================================================
ERROR: test_send_contact (tests.test_bot.BotTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/tests/base.py", line 84, in newfunc
    rc = func(*args, **kwargs)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/tests/test_bot.py", line 353, in test_send_contact
    message = self._bot.send_contact(self._chat_id, phone, name, last)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/bot.py", line 124, in decorator
    result = func(self, *args, **kwargs)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/bot.py", line 150, in decorator
    result = self._request.post(url, data, timeout=kwargs.get('timeout'))
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/utils/request.py", line 205, in post
    **urlopen_kwargs)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/utils/request.py", line 156, in _request_wrapper
    raise NetworkError('{0} ({1})'.format(message, resp.status))
telegram.error.NetworkError: Too Many Requests: retry after 24518 (429)

I think it will be very hard to test, because such errors could emerge everywhere during repeating tests.

Contributor

lisitsky commented Nov 7, 2016

Travis says, it got HTTP Error 429 "Too many requests" from Telegram API during tests:

======================================================================
ERROR: test_send_contact (tests.test_bot.BotTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/tests/base.py", line 84, in newfunc
    rc = func(*args, **kwargs)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/tests/test_bot.py", line 353, in test_send_contact
    message = self._bot.send_contact(self._chat_id, phone, name, last)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/bot.py", line 124, in decorator
    result = func(self, *args, **kwargs)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/bot.py", line 150, in decorator
    result = self._request.post(url, data, timeout=kwargs.get('timeout'))
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/utils/request.py", line 205, in post
    **urlopen_kwargs)
  File "/home/travis/build/python-telegram-bot/python-telegram-bot/telegram/utils/request.py", line 156, in _request_wrapper
    raise NetworkError('{0} ({1})'.format(message, resp.status))
telegram.error.NetworkError: Too Many Requests: retry after 24518 (429)

I think it will be very hard to test, because such errors could emerge everywhere during repeating tests.

@jh0ker jh0ker added the enhancement label Dec 18, 2016

@jh0ker

This comment has been minimized.

Show comment
Hide comment
@jh0ker

jh0ker Dec 18, 2016

Member

OK I fixed the pre-commit hooks, so I'll merge

Member

jh0ker commented Dec 18, 2016

OK I fixed the pre-commit hooks, so I'll merge

@jh0ker jh0ker merged commit c3984e1 into python-telegram-bot:master Dec 18, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 92.652%
Details
@OctoNezd

This comment has been minimized.

Show comment
Hide comment
@OctoNezd

OctoNezd Dec 18, 2016

Contributor

yay

Contributor

OctoNezd commented Dec 18, 2016

yay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment