Testing #51
Merged
Testing #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 2, 2015 16:04
Not everything has a test. and I'm quite new to unit testing so I'm not sure if I am doing this the right way.
I saw in the TODO list on pypi that you wanted a commandhandler. I am not sure about the run and run_once commands. and I didn't implement logging yet.
this is an example of how to write a commandHandler
|
W00t!!! Nicely done! Thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a CommandHandler and an example for how to use it. I also added a unit test but i am new to unittesting so i dont know if I am doing it the right way.
I also am not sure if the run and run_once methods are fine.
They do work but I don't know if there is a better way to make such methods.