-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Socks5 proxy. #518
Conversation
It looks okay to me, did you do a manual test to see if it works for you? |
BTW, you also have to edit the requirements accordingly (at least for travis) to prevent this error:
|
@jh0ker Get it. Thanks for your tips. |
@jh0ker I did a manual test, and it works well. |
@jh0ker Any idea on this issue? |
@daimajia that is expected behavior, no need for your to worry |
BTW. This issue It looks all right for this PR. 😃 |
It would be preferred to list the dependency as an extra dependency, similar to |
Good suggestion. I'll finish it ASAP. |
@jh0ker Remove the |
Optimize import.
@jh0ker How about now? |
@daimajia yes, please |
@jh0ker Done, please check it. |
@daimajia Thank you for your good work. That's something we'd really like.
|
right? @tsnoam |
@daimajia |
@tsnoam Thanks. ❤️ |
@daimajia |
@tsnoam Thanks, I'm pretty willing to add myself to the contributors list, I'm proud of contributing to this lib. 😊 |
fix #517
I'm not quite sure if I'm doing the right thing. 🤣
Please comment if I'm making mistake. 🗣