-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filters to commandHandler #536
Conversation
I'm looking forward to this, but I think you will have to write some tests for this to get it pulled. |
Do you mean a test on test_updater.py? like: I didn't find any more tests of commandHandler, thanks for the feedback. |
@jossalgon Yes, indeed. Just add one test case where the filter allows the message and one test case where it doesn't, then we're good to merge I think 👍 |
Are the tests ok in this way? |
Great, but the name of the two test functions says |
👍 sorry, the commit is now amended |
I'll let the tests run through on Travis before merging, but it looks good. Thank you very much for your contribution :) Did you already add yourself to |
Not yet, I'll add a commit with that and it's a pleasure to collaborate :) |
Would you mind adding me to authors to? I forgot and to make a single PR just for that :D |
@Eldinnie I can just commit that directly to master, no need to piggyback it here @jossalgon ^^ |
anyways, tests look good so I'll merge now! |
Add filters to CommandHandler.
Now you can filter commands, for example to separate a command from group and private or any filter you want.
where filter_example is:
or