New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log error trace if there is no error handler registered #694

Merged
merged 3 commits into from Oct 21, 2017

Conversation

Projects
None yet
4 participants
@jh0ker
Member

jh0ker commented Jun 29, 2017

No description provided.

@jsmnbom

This comment has been minimized.

Show comment
Hide comment
@jsmnbom

jsmnbom Aug 12, 2017

Member

Could you maybe merge from master so tests are updated (so we can get the build to not fail)

Member

jsmnbom commented Aug 12, 2017

Could you maybe merge from master so tests are updated (so we can get the build to not fail)

@tsnoam

This comment has been minimized.

Show comment
Hide comment
@tsnoam

tsnoam Oct 20, 2017

Member

merged from master

Member

tsnoam commented Oct 20, 2017

merged from master

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 20, 2017

Codecov Report

Merging #694 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   91.73%   91.74%   +<.01%     
==========================================
  Files         101      101              
  Lines        4055     4057       +2     
  Branches      620      621       +1     
==========================================
+ Hits         3720     3722       +2     
  Misses        197      197              
  Partials      138      138
Flag Coverage Δ
#Appveyor 86.88% <100%> (ø) ⬆️
#Travis 91.32% <100%> (ø) ⬆️
Impacted Files Coverage Δ
telegram/ext/dispatcher.py 92.81% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38637ec...e7e9837. Read the comment docs.

codecov bot commented Oct 20, 2017

Codecov Report

Merging #694 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   91.73%   91.74%   +<.01%     
==========================================
  Files         101      101              
  Lines        4055     4057       +2     
  Branches      620      621       +1     
==========================================
+ Hits         3720     3722       +2     
  Misses        197      197              
  Partials      138      138
Flag Coverage Δ
#Appveyor 86.88% <100%> (ø) ⬆️
#Travis 91.32% <100%> (ø) ⬆️
Impacted Files Coverage Δ
telegram/ext/dispatcher.py 92.81% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38637ec...e7e9837. Read the comment docs.

@tsnoam tsnoam merged commit 3ed0599 into master Oct 21, 2017

5 checks passed

codeclimate All good!
Details
codecov/patch 100% of diff hit (target 91.73%)
Details
codecov/project 91.74% (+<.01%) compared to 38637ec
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tsnoam tsnoam deleted the no-error-handler branch Oct 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment