-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log error trace if there is no error handler registered #694
Conversation
telegram/ext/dispatcher.py
Outdated
raise error | ||
|
||
except: | ||
self.logger.exception('No error handlers are registered, logging exception...') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it'll be better to use self.logger.exception('...', exc_info=error)
instead of this try-except clause?
Could you maybe merge from master so tests are updated (so we can get the build to not fail) |
merged from master |
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
+ Coverage 91.73% 91.74% +<.01%
==========================================
Files 101 101
Lines 4055 4057 +2
Branches 620 621 +1
==========================================
+ Hits 3720 3722 +2
Misses 197 197
Partials 138 138
Continue to review full report at Codecov.
|
No description provided.