New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sane defaults for tcp socket options #754

Merged
merged 2 commits into from Jul 29, 2017

Conversation

Projects
None yet
2 participants
@tsnoam
Member

tsnoam commented Jul 28, 2017

Currently only for linux as most of our userbase is there.

fixes #535

tsnoam added some commits Jul 28, 2017

Sane defaults for tcp socket options
Currently only for linux as most of our userbase is there.

fixes #535

@tsnoam tsnoam merged commit 5d3f557 into master Jul 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on master at 86.279%
Details

@tsnoam tsnoam deleted the sane_tcp_sock_opts branch Jul 29, 2017

@jsmnbom

This comment has been minimized.

Show comment
Hide comment
@jsmnbom

jsmnbom Jul 29, 2017

Member

I know you implemented this already, but wouldn't it be better to check if current platform has those socket capabilities instead of checking the platform?

Member

jsmnbom commented Jul 29, 2017

I know you implemented this already, but wouldn't it be better to check if current platform has those socket capabilities instead of checking the platform?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment