-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore text_* #777
restore text_* #777
Conversation
I modified as requested. |
Hmm maybe add a docstring link from the urled one to the not urled one and vise versa? |
@bomjacob they should be listed right on top of each other in docstrings. I think it's a bit overkill |
That may be true, but I still think it makes more sense from a usability standpoint. Especially if you consider that people don't necessarily search through the docs themselves, they might be linked by roolsbot or be using the internal help() command. |
@bomjacob does not encode if the user didn't use html tags, but does it returns the html tags if the user sent the message using them? |
@91DarioDev in that case it would be a MessageEntity.TEXT_LINK which is always encoded |
LGTM. @Eldinnie has proper unitest wip with the new unitests so no need for that here. |
This restores the text_* properties for message to the way they were.
Implementing different methods for different behavior can be done either in this PR or in another.
fixes #773