Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on branch coverage #790

Merged
merged 6 commits into from
Sep 1, 2017
Merged

Turn on branch coverage #790

merged 6 commits into from
Sep 1, 2017

Conversation

jsmnbom
Copy link
Member

@jsmnbom jsmnbom commented Aug 12, 2017

Just testing for now

@Eldinnie
Copy link
Member

@bomjacob regarding this, It seems to be working now?

@jsmnbom
Copy link
Member Author

jsmnbom commented Aug 12, 2017

Sometimes yeah... but imo sometimes isn't good enough

@Eldinnie
Copy link
Member

I let travis build 5 times and it completed all successful, I would think that;s good enough?

@jsmnbom
Copy link
Member Author

jsmnbom commented Aug 12, 2017

I mean we can try?
The fact of the matter is that it's failed before though and I have no idea if these changes actually changed anything

@Eldinnie
Copy link
Member

@bomjacob Having to rerun a build once in a while has happened before with other tests. It runs pretty stable now, I think this could be merged

@Eldinnie Eldinnie merged commit 8cda3f7 into master Sep 1, 2017
@Eldinnie Eldinnie deleted the branch-coverage branch September 1, 2017 06:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants