Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on small con_pool_size during custom initalization of Updater #793

Merged
merged 1 commit into from Aug 12, 2017

Conversation

Projects
None yet
2 participants
@tsnoam
Copy link
Member

tsnoam commented Aug 12, 2017

fixes #787

@jsmnbom

This comment has been minimized.

Copy link
Member

jsmnbom commented Aug 12, 2017

Can we test it?
(other than that it looks good)

@tsnoam

This comment has been minimized.

Copy link
Member Author

tsnoam commented Aug 12, 2017

@bomjacob I'm not sure how can we test log prints.
In any case, this warning is for the benefit of the very advanced users.

@jsmnbom

This comment has been minimized.

Copy link
Member

jsmnbom commented Aug 12, 2017

It's easily done with pytest, but you're probably right in that we don't need it :)

@tsnoam tsnoam merged commit ee34d57 into master Aug 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 91.011%
Details

@tsnoam tsnoam deleted the warn_on_small_conpool branch Aug 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.