Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on small con_pool_size during custom initalization of Updater #793

Merged
merged 1 commit into from
Aug 12, 2017

Conversation

tsnoam
Copy link
Member

@tsnoam tsnoam commented Aug 12, 2017

fixes #787

@jsmnbom
Copy link
Member

jsmnbom commented Aug 12, 2017

Can we test it?
(other than that it looks good)

@tsnoam
Copy link
Member Author

tsnoam commented Aug 12, 2017

@bomjacob I'm not sure how can we test log prints.
In any case, this warning is for the benefit of the very advanced users.

@jsmnbom
Copy link
Member

jsmnbom commented Aug 12, 2017

It's easily done with pytest, but you're probably right in that we don't need it :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urllib + MessageQueue = Connection pool is full warning
2 participants