Bot API 3.3 #806

jeffffc · 2017-08-23T06:37:05Z

Bot API 3.3
https://core.telegram.org/bots/api#august-23-2017

added forward_signature and author-signature to Message
added is_bot to User
added pinned_message to Chat
added mention() to telegram.utils.helpers for easy generation of inline text mentions with (id/User/Message) input

edit: i have no idea why it cannot import Message...

jsmnbom · 2017-08-23T08:50:55Z

You caused a circular import error please fix in __init__.py
I'm not a fan of mention tbh. It should be either follow our convention of "_html" and "_markdown" or work like send_message and accept a parsemode.
I also feel like it's weird that it accepts a Message object, what's the basis for that decision?
Also why is the name overwriteable?

Eldinnie

I made some comments in the code.

Also I personally would prefer to do the mention a little different. A bit like @bomjacob suggested I would prefer it to be a helper within the telegram.User object.
So that you get:

user = telegram.User
user.mention_html == "<a href='tg:://user?self.id'>self.name</a>"

Users can then use
message.from_user.mention_markdown in their code for example.

Eldinnie · 2017-08-23T10:07:41Z

telegram/chat.py

@@ -57,6 +59,8 @@ class Chat(TelegramObject):
            Returned only in get_chat.
        invite_link (:obj:`str`, optional): Chat invite link, for supergroups and channel chats.
            Returned only in get_chat.
+        pinned_message (:class:`telegram.Message`, optional): Pinned message, for supergroups.
+            Returned only in getChat.


Please use get_chat

Eldinnie · 2017-08-23T10:07:58Z

telegram/chat.py

@@ -37,6 +37,8 @@ class Chat(TelegramObject):
        photo (:class:`telegram.ChatPhoto`): Optional. Chat photo.
        description (:obj:`str`): Optional. Description, for supergroups and channel chats.
        invite_link (:obj:`str`): Optional. Chat invite link, for supergroups and channel chats.
+        pinned_message (:class:`telegram.Message`): Optional. Pinned message, for supergroups.
+            Returned only in getChat.


please use get_chat

Eldinnie · 2017-08-23T10:12:49Z

telegram/utils/helpers.py

+            Optional if User or Message is provided and will overwrite the name in user.
+
+    Returns:
+        str:


Please define return as :obj :str: The inline mention for the user as html or markdown.

Eldinnie · 2017-08-23T10:13:13Z

telegram/utils/helpers.py

+    if not user:
+        return None
+
+    if isinstance(user, Message):


I would skip this, also see the total review comment.

Eldinnie · 2017-08-23T10:15:43Z

telegram/utils/helpers.py

+
+    elif isinstance(user, User):
+        if not name:
+            if user.last_name:


The user object already has a name-property, wouldn;t it make more sense to use that?
https://github.com/python-telegram-bot/python-telegram-bot/blob/master/telegram/user.py#L67

Eldinnie · 2017-08-23T10:16:24Z

tests/test_message.py

-                                                             order_info={})}
+                                                             order_info={})},
+                    {'forward_signature': 'some_forward_sign'},
+                    {'author_signature': 'some_autohr_sign'}


Spell mistake (although no big deal in tests, but still.

Eldinnie · 2017-08-23T10:22:34Z

Hey @jeffffc . Thanks for your work!

I made a few adjustment requests in a code comment, Als o please see my suggestion regarding the mention helper. What do you think about that approach?
Also @bomjacob I like the way you can choose the name for the mention, say you want to rank players and name them first, second etc. in your message.

Lastly can you fix the import trouble? So we can see what Travis thinks about it.

Pieter

jeffffc · 2017-08-23T12:31:02Z

Let me answer and clarify before pushing updates.
@bomjacob
For 2, I will divide it into 2 functions then. For 3, yea i just thought that from my instinct, maybe that is not necessary, i will remove it. For 4, it was because for the text mention you do not necessarily use the real name of the user, for example you can make it as [I want something random](tg://user?id=123456789), but if you do not pass the name then it uses the user's name by default. I hope i made myself clear on this issue.
@Eldinnie
Sure It is sensible to make it into user object, i didnt think of that! For the User.name object yes I did notice the existence of it but as I wrote above, the text_mention can be showing manual-input strings but not a must to be its name. Moreover, for users who have usernames, User.name is default outputting their username, i don't when people using text_mentions on these users would want to show their username directly?

Thank you both for your response and I will surely fix the circular import issue.

Eldinnie · 2017-08-23T16:23:22Z

@jeffffc you make a good point. I was merely saying that the fallback could be the name property, but I agree you should be able to set the name. So maybe properties for the mention_html/markdown isn't useful.

How about two helper methods within telegram.User

def mention_html(name=None) -> str (<a href ...>)
    
def mention_markdown(name=None) -> str ([name](...))

jeffffc · 2017-08-23T16:41:11Z

@Eldinnie sure.
Just one more thing atm: the new pinned_message is a message object within a chat object, while the current message object already imported chat object. How should i do to prevent the circular import? i tried to look it up but cant seems to find any good solution..

Eldinnie · 2017-08-23T16:42:04Z

@jeffffc ouch, ehm, not at pc right now... I can look into it later.

attempt to fix circular import (not sure if its the correct way tho) added helper methods into User object

jeffffc · 2017-08-23T18:51:16Z

The errors in travis tests should not be mine now.
So the changes now are:

User object
--> User.mention_markdown(name=None) and User.mention_html(name=None)
--> If name not passed, will use User.name by default
utils.helpers
--> mention_markdown(user_id, name) and mention_html(user_id, name)
--> assuming users will pass custom names

Eldinnie · 2017-08-23T20:40:08Z

@jeffffc Looks good to me, also thanks for fixing all the tests. There's one flake8 error:
telegram/user.py:28:1: E303 too many blank lines (3)
Can you fix that last one? Then imo it's good to merge @tsnoam @jh0ker

jeffffc · 2017-08-23T20:42:44Z

you're welcome!
sure, i missed it my bad, just pushed a new commit.

jh0ker · 2017-08-23T20:47:07Z

Looks good, thank you for your work :)

Eldinnie · 2017-08-23T23:06:51Z

The tests failing are failing due to sticker trouble. #807 should fix those.

evgfilim1 · 2017-08-24T07:54:19Z

telegram/user.py

+            :obj:`str`: The inline mention for the user as HTML.
+        """
+        if not name:
+            return util_mention_html(self.name, self.id)


You've mixed up arguments. First is user_id, second is name

you are absolutely right. I mixed up with the old versions. thank you for spotting it out. pushing new commit now.

oops, good spot.

evgfilim1 · 2017-08-24T07:54:31Z

telegram/user.py

+        if not name:
+            return util_mention_html(self.name, self.id)
+        else:
+            return util_mention_html(name, self.id)


See comment above

Eldinnie · 2017-08-26T20:14:53Z

Changed the base to 7.1-branch

evgfilim1 · 2017-09-01T07:01:50Z

🎉

jeffffc · 2017-09-01T08:30:33Z

just wondering why travis keep saying build is in progress even all tests passed

Eldinnie · 2017-09-01T08:31:04Z

@jeffffc I stopped travis to fix an error localy. Will push in a sec..

jeffffc · 2017-09-01T08:31:24Z

i see, thanks

alexpacini · 2017-10-11T13:47:15Z

I suggest to edit the readme to reflect that API v3.3 is supported

Eldinnie · 2017-10-11T14:16:52Z

@alexpacini Good point, although I hope we can skip that and just jump to 3.4 in a few days.

Bot API 3.3

0818550

Eldinnie requested changes Aug 23, 2017

View reviewed changes

jeffffc added 3 commits August 24, 2017 01:01

simpler helper methods (accept only custom names now)

fdc91e4

attempt to fix circular import (not sure if its the correct way tho) added helper methods into User object

fix User objects in tests to contain is_bot required value

2f79cca

fix User objects in tests to contain is_bot required value

0a0d9b8

Eldinnie approved these changes Aug 23, 2017

View reviewed changes

delete extra line that caused flake8 error

2f18ccb

Eldinnie requested a review from tsnoam August 23, 2017 20:43

jh0ker approved these changes Aug 23, 2017

View reviewed changes

Eldinnie mentioned this pull request Aug 23, 2017

Fix sticker tests #807

Merged

jsmnbom added the pending merge label Aug 24, 2017

evgfilim1 suggested changes Aug 24, 2017

View reviewed changes

fix swapped arguments

fc24095

evgfilim1 approved these changes Aug 24, 2017

View reviewed changes

Eldinnie changed the base branch from master to 7.1-branch August 26, 2017 20:14

jsmnbom changed the base branch from 7.1-branch to master August 26, 2017 20:22

Eldinnie merged commit b6a0853 into python-telegram-bot:master Sep 1, 2017

pyup-bot mentioned this pull request Nov 1, 2017

Scheduled monthly dependency update for November Findus23/nonsense#31

Closed

pyup-bot mentioned this pull request Dec 1, 2017

Scheduled monthly dependency update for December Findus23/nonsense#32

Closed

pyup-bot mentioned this pull request Jan 22, 2018

Pin python-telegram-bot to latest version 9.0.0 skeledrew/ratot#2

Closed

This was referenced Mar 2, 2018

Pin python-telegram-bot to latest version 10.0.0 skeledrew/ratot#11

Closed

Pin python-telegram-bot to latest version 10.0.1 skeledrew/ratot#12

Merged

github-actions bot locked and limited conversation to collaborators Aug 22, 2020

harshil21 added API and removed pending merge labels Mar 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bot API 3.3 #806

Bot API 3.3 #806

jeffffc commented Aug 23, 2017 •

edited

Loading

jsmnbom commented Aug 23, 2017

Eldinnie left a comment •

edited

Loading

Eldinnie Aug 23, 2017

Eldinnie Aug 23, 2017

Eldinnie Aug 23, 2017

Eldinnie Aug 23, 2017

Eldinnie Aug 23, 2017

Eldinnie Aug 23, 2017

Eldinnie commented Aug 23, 2017

jeffffc commented Aug 23, 2017

Eldinnie commented Aug 23, 2017 •

edited

Loading

jeffffc commented Aug 23, 2017 •

edited

Loading

Eldinnie commented Aug 23, 2017

jeffffc commented Aug 23, 2017

Eldinnie commented Aug 23, 2017

jeffffc commented Aug 23, 2017

jh0ker commented Aug 23, 2017

Eldinnie commented Aug 23, 2017

evgfilim1 Aug 24, 2017

jeffffc Aug 24, 2017

Eldinnie Aug 24, 2017

evgfilim1 Aug 24, 2017

Eldinnie commented Aug 26, 2017

evgfilim1 commented Sep 1, 2017

jeffffc commented Sep 1, 2017

Eldinnie commented Sep 1, 2017

jeffffc commented Sep 1, 2017

alexpacini commented Oct 11, 2017

Eldinnie commented Oct 11, 2017

Bot API 3.3 #806

Bot API 3.3 #806

Conversation

jeffffc commented Aug 23, 2017 • edited Loading

jsmnbom commented Aug 23, 2017

Eldinnie left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eldinnie commented Aug 23, 2017

jeffffc commented Aug 23, 2017

Eldinnie commented Aug 23, 2017 • edited Loading

jeffffc commented Aug 23, 2017 • edited Loading

Eldinnie commented Aug 23, 2017

jeffffc commented Aug 23, 2017

Eldinnie commented Aug 23, 2017

jeffffc commented Aug 23, 2017

jh0ker commented Aug 23, 2017

Eldinnie commented Aug 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Eldinnie commented Aug 26, 2017

evgfilim1 commented Sep 1, 2017

jeffffc commented Sep 1, 2017

Eldinnie commented Sep 1, 2017

jeffffc commented Sep 1, 2017

alexpacini commented Oct 11, 2017

Eldinnie commented Oct 11, 2017

jeffffc commented Aug 23, 2017 •

edited

Loading

Eldinnie left a comment •

edited

Loading

Eldinnie commented Aug 23, 2017 •

edited

Loading

jeffffc commented Aug 23, 2017 •

edited

Loading