New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Bot._message_wrapper #822

Merged
merged 4 commits into from Oct 11, 2017

Conversation

Projects
None yet
3 participants
@Eldinnie
Member

Eldinnie commented Sep 10, 2017

Moved tho code to the @message decorator instead

Fixes #752

remove Bot._message_wrapper
Moved tho code to the @message decorator instead
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 10, 2017

Codecov Report

Merging #822 into master will decrease coverage by 1.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   91.89%   90.69%   -1.21%     
==========================================
  Files         101      101              
  Lines        3987     3985       -2     
  Branches      603      577      -26     
==========================================
- Hits         3664     3614      -50     
- Misses        187      218      +31     
- Partials      136      153      +17
Flag Coverage Δ
#Appveyor ?
#Travis 90.69% <100%> (-0.84%) ⬇️
Impacted Files Coverage Δ
telegram/bot.py 87.43% <100%> (-0.58%) ⬇️
telegram/files/inputfile.py 79.72% <0%> (-10.82%) ⬇️
telegram/base.py 89.74% <0%> (-10.26%) ⬇️
telegram/utils/helpers.py 70% <0%> (-10%) ⬇️
telegram/games/game.py 94.28% <0%> (-5.72%) ⬇️
telegram/ext/messagequeue.py 65.06% <0%> (-4.82%) ⬇️
telegram/utils/webhookhandler.py 92.77% <0%> (-4.82%) ⬇️
telegram/message.py 91.23% <0%> (-4.79%) ⬇️
telegram/utils/request.py 64.28% <0%> (-2.68%) ⬇️
telegram/ext/conversationhandler.py 79.27% <0%> (-1.81%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445bcde...2c4e282. Read the comment docs.

codecov bot commented Sep 10, 2017

Codecov Report

Merging #822 into master will decrease coverage by 1.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #822      +/-   ##
==========================================
- Coverage   91.89%   90.69%   -1.21%     
==========================================
  Files         101      101              
  Lines        3987     3985       -2     
  Branches      603      577      -26     
==========================================
- Hits         3664     3614      -50     
- Misses        187      218      +31     
- Partials      136      153      +17
Flag Coverage Δ
#Appveyor ?
#Travis 90.69% <100%> (-0.84%) ⬇️
Impacted Files Coverage Δ
telegram/bot.py 87.43% <100%> (-0.58%) ⬇️
telegram/files/inputfile.py 79.72% <0%> (-10.82%) ⬇️
telegram/base.py 89.74% <0%> (-10.26%) ⬇️
telegram/utils/helpers.py 70% <0%> (-10%) ⬇️
telegram/games/game.py 94.28% <0%> (-5.72%) ⬇️
telegram/ext/messagequeue.py 65.06% <0%> (-4.82%) ⬇️
telegram/utils/webhookhandler.py 92.77% <0%> (-4.82%) ⬇️
telegram/message.py 91.23% <0%> (-4.79%) ⬇️
telegram/utils/request.py 64.28% <0%> (-2.68%) ⬇️
telegram/ext/conversationhandler.py 79.27% <0%> (-1.81%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 445bcde...2c4e282. Read the comment docs.

@jsmnbom

I can't believe we didn't do this sooner xD

@tsnoam tsnoam merged commit 2aa456d into master Oct 11, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codeclimate All good!
Details

@tsnoam tsnoam deleted the fix-752 branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment