Added utils.helpers.effective_message_type

[JosXa]

I've added a TODO tag in the helpers file where cyclic imports would happen if I didn't put the import statements inside of the method. This should be fixed before merging.

[Eldinnie]

I rebased on master. Two things I would like to see on this.
Tests for all occurencies (no type, and an update passed instead of a message)
And please revert the param line in test_message

[Eldinnie]

Tests for all occurencies (no type, and an update passed instead of a message)
And please revert the param line in test_message

[Eldinnie]

@JosXa what is the status for this?

[JosXa]

@Eldinnie I don't have much time atm. Hope to get to all my open issues end of the week

[Eldinnie]

@JosXa 👍

[JosXa]

Made changes as requested.

Question remains: Can/should we do something about the cyclic import (see helpers.py, "TODO")?

[JosXa]

Integration tests fail because of flood timeouts etc. PR lgtm.

[codecov]

Codecov Report

Merging #826 into master will decrease coverage by 0.18%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
- Coverage   91.83%   91.64%   -0.19%     
==========================================
  Files         103      103              
  Lines        4052     4070      +18     
  Branches      639      645       +6     
==========================================
+ Hits         3721     3730       +9     
- Misses        193      198       +5     
- Partials      138      142       +4

Impacted Files	Coverage Δ
telegram/message.py	96.26% <100%> (-0.73%)	⬇️
telegram/utils/helpers.py	82.6% <83.33%> (+0.25%)	⬆️
telegram/utils/request.py	67.85% <0%> (-0.9%)	⬇️
telegram/bot.py	87.57% <0%> (-0.44%)	⬇️

[tsnoam]

@Eldinnie @JosXa
lgtm
i added two small commits.
i think we can merge after CI

[Eldinnie]

Coverage is not 100% because this case is never tested:
https://github.com/python-telegram-bot/python-telegram-bot/pull/826/files#diff-f070280279d9dc7a6c79eb51d4ab9156R140
Not a very big problem to me.
Good to merge