New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods to quickly reply to a message with Markdown or HTML #827

Merged
merged 14 commits into from Feb 12, 2018

Conversation

Projects
None yet
3 participants
@JosXa
Contributor

JosXa commented Sep 11, 2017

I had problems mergin urllib3, so this PR closes #725.

@Eldinnie Indentation adjusted as per your request.

Tests are probably gonna have to wait until pytest stops messing up my workflow...

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 14, 2017

Codecov Report

Merging #827 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   91.83%   91.67%   -0.16%     
==========================================
  Files         103      103              
  Lines        4052     4061       +9     
  Branches      639      639              
==========================================
+ Hits         3721     3723       +2     
- Misses        193      197       +4     
- Partials      138      141       +3
Impacted Files Coverage Δ
telegram/message.py 96.36% <100%> (-0.63%) ⬇️
telegram/utils/request.py 67.85% <0%> (-0.9%) ⬇️
telegram/bot.py 87.51% <0%> (-0.5%) ⬇️

codecov bot commented Sep 14, 2017

Codecov Report

Merging #827 into master will decrease coverage by 0.15%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   91.83%   91.67%   -0.16%     
==========================================
  Files         103      103              
  Lines        4052     4061       +9     
  Branches      639      639              
==========================================
+ Hits         3721     3723       +2     
- Misses        193      197       +4     
- Partials      138      141       +3
Impacted Files Coverage Δ
telegram/message.py 96.36% <100%> (-0.63%) ⬇️
telegram/utils/request.py 67.85% <0%> (-0.9%) ⬇️
telegram/bot.py 87.51% <0%> (-0.5%) ⬇️
@Eldinnie

This comment has been minimized.

Show comment
Hide comment
@Eldinnie

Eldinnie Sep 14, 2017

Member

I edited the docstring and merged master. But it's still missing tests for these new methods.
Please add using monkeypatch. See test_message::test_reply_text for example

Member

Eldinnie commented Sep 14, 2017

I edited the docstring and merged master. But it's still missing tests for these new methods.
Please add using monkeypatch. See test_message::test_reply_text for example

@Eldinnie

But it's still missing tests for these new methods.
Please add using monkeypatch. See test_message::test_reply_text for example

@Eldinnie

This comment has been minimized.

Show comment
Hide comment
@Eldinnie

Eldinnie Sep 25, 2017

Member

@JosXa what is the status for this?

Member

Eldinnie commented Sep 25, 2017

@JosXa what is the status for this?

@JosXa

This comment has been minimized.

Show comment
Hide comment
@JosXa

JosXa Oct 2, 2017

Contributor

Tests added as discussed

Contributor

JosXa commented Oct 2, 2017

Tests added as discussed

JosXa added some commits Oct 2, 2017

@JosXa

This comment has been minimized.

Show comment
Hide comment
@JosXa

JosXa Oct 2, 2017

Contributor

Sorry, I keep committing files from other branches... Fixed now.

Contributor

JosXa commented Oct 2, 2017

Sorry, I keep committing files from other branches... Fixed now.

@JosXa JosXa added the enhancement label Oct 7, 2017

@JosXa JosXa self-assigned this Oct 7, 2017

@Eldinnie

Some small docstring improvements and please restore the dict in test_message to the state it was.

Other than that it looks good to me.

Show outdated Hide outdated telegram/message.py
Show outdated Hide outdated telegram/message.py
Show outdated Hide outdated tests/test_message.py

JosXa added some commits Feb 1, 2018

Merge remote-tracking branch 'remotes/origin/master' into extract-urls
# Conflicts:
#	telegram/utils/helpers.py
@tsnoam

This comment has been minimized.

Show comment
Hide comment
@tsnoam

tsnoam Feb 10, 2018

Member

The code itself LGTM.

However, I think it's over-engineering and only bloats the code. Though if the other maintainers find it suitable for ptb, I won't object.

Member

tsnoam commented Feb 10, 2018

The code itself LGTM.

However, I think it's over-engineering and only bloats the code. Though if the other maintainers find it suitable for ptb, I won't object.

@tsnoam

This comment has been minimized.

Show comment
Hide comment
@tsnoam

tsnoam Feb 12, 2018

Member

@jh0ker thinks it a good idea to have this in the library. merging.

Member

tsnoam commented Feb 12, 2018

@jh0ker thinks it a good idea to have this in the library. merging.

@tsnoam tsnoam merged commit f0dfdfb into master Feb 12, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
codeclimate All good!
Details

@tsnoam tsnoam deleted the reply-text-markdown-2 branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment