Join GitHub today
support 3.4 API #865
@@ Coverage Diff @@ ## master #865 +/- ## ========================================== - Coverage 91.89% 91.76% -0.14% ========================================== Files 101 101 Lines 3987 4055 +68 Branches 603 620 +17 ========================================== + Hits 3664 3721 +57 - Misses 187 196 +9 - Partials 136 138 +2
Ok I think I got everything in. Something weird going on with test_official. I don't really get the error. I'm hoping @bomjacob can find time to figure it out.
Also we need to let the bot set a stickerset on our group every test (going to be problematic I'm affraid) to properly test the
I found the problem with test_official.
All changes looks good.
However, the thing with a 2nd CR is that you see the things you haven't seen the first time.
I think that location should be mutually exclusive to (longitude, latitude). You can do something like to make sure that one and only one of the two is supplied:
if not (None not in (longitude, latitude)) ^ bool(location): raise Exception...