Add support for the anyio library #120
Conversation
There was a problem hiding this comment.
This is shockingly easy for such a conversion - huge kudos to you for an implementation that made this feasible, and @agronholm for a super-clean drop in library 馃檶
A few things before this is ready to ship are listed in comments below; happy to do those here or in a follow-up PR as you prefer.
馃 I should probably also run this past @agronholm too, in case I missed something...
|
Fixed all review comments (or disabled functionality and moved out to separate issues). Also did some refactoring to make stuff cleaner, added |
|
|
||
|
|
||
| async def foo(): | ||
| nursery = anyio.open_nursery() |
There was a problem hiding this comment.
Probably worth a comment that all this is fine because anyio calls the equivalent construct a "taskgroup", following asyncio?
There was a problem hiding this comment.
Following curio, actually. Asyncio got task groups much later than either curio or AnyIO.
| ... | ||
| except ValueError: | ||
| await foo() # safe | ||
| except anyio.Cancelled: |
There was a problem hiding this comment.
I presume this will be updated in a future PR 馃憤
There was a problem hiding this comment.
The AnyIO way to do this is except anyio.get_cancelled_exc_class():.
There was a problem hiding this comment.
Yep, discussed in #120 (comment) and tracked in #122 馃檪
There was a problem hiding this comment.
Yeah that check is to make sure it doesn't raise an error - regardless of if it exists as a library function or not. Can add a comment with #122
Fixes #61
Have fun with this tiny commit 馃檭
Kind of a chore, I maybe should have gone at some parts in different ways, but the library should now have full support for anyio - and all eval files are tested with "trio" replaced with "anyio", looking to see that all the errors are still good, and that there's no instances of "trio" in the output.
If you trigger an error without importing either trio or anyio, the library will default to saying "trio" in error messages. If you trigger an error having imported both, it will say stuff like
Otherwise it's not too much that's actually changed, just lots of small replacements in a billion places.