Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

Add Request and RequestData APIs #185

Closed
wants to merge 3 commits into from

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Dec 2, 2019

Opening this branch instead of #151 mostly due to working out of my fork and not using more CI than needed.

I've responded to the comments and moved to a much simpler interface for RequestData that is mostly a Content-Type attached to a byte iterator factory.

Currently Request and RequestData aren't connected in any way, I'm not sure if they need to be if they mostly live within the scope of Session.request() anyways. We never present a Request to a user with a body on it.

Also another note here is that our interface now only presents URL and Headers, even when calling request.headers = {} you'll receive a Headers object from x = request.headers

@sethmlarson
Copy link
Contributor Author

Closing these API PRs in favor of a scratch branch.

@sethmlarson sethmlarson closed this Dec 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant