note some issues in the code

python-trio · Apr 15, 2022 · 1e8f8e9 · 1e8f8e9
1 parent 64c5fe4
commit 1e8f8e9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/purerpc/__init__.py b/src/purerpc/__init__.py
@@ -1,5 +1,6 @@
 from .anyio_monkeypatch import apply_monkeypatch as _apply_anyio_monkeypatch
 
+# TODO: don't hack anyio.run()!
 _apply_anyio_monkeypatch()
 
 

diff --git a/src/purerpc/server.py b/src/purerpc/server.py
@@ -218,10 +218,12 @@ async def request_received(self, stream: GRPCProtoStream):
             except RpcFailedError as error:
                 await stream.close(error.status)
             except:
+                # TODO: limit catch to Exception, so async cancel can propagate
                 log.warning("Got exception while writing response stream",
                             exc_info=log.getEffectiveLevel() == logging.DEBUG)
                 await stream.close(Status(StatusCode.CANCELLED, status_message=repr(sys.exc_info())))
         except:
+            # TODO: limit catch to Exception, so async cancel can propagate
             log.warning("Got exception in request_received",
                         exc_info=log.getEffectiveLevel() == logging.DEBUG)
 
@@ -236,5 +238,6 @@ async def __call__(self, socket):
                     async for stream in self.grpc_socket.listen():
                         await task_group.spawn(self.request_received, stream)
         except:
+            # TODO: limit catch to Exception, so async cancel can propagate
             log.warning("Got exception in main dispatch loop",
                         exc_info=log.getEffectiveLevel() == logging.DEBUG)