More robust /-command parsing #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to have a 'raise NotImplementedError' here, and as soon as this was deployed we hit that error, from an issue that contained some Python warning messages, which start with an absolute path, and the path starts with a /. Whoops. I don't think there's any better way to handle these except to just ignore them.
This is probably overkill, but: - It means we won't parse commands embedded in e.g. code blocks or blockquotes, which seems like it would be surprising (and make it hard to talk about commands without invoking them) - It's only a few lines of code - I had fun Unfortunately, the mistletoe markdown parser doesn't know about HTML comments, so it *will* still process invisible commands embedded inside <!-- -->. That seems like a bug, but I'm not sure how to fix it...
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 94.47% 94.59% +0.12%
==========================================
Files 11 11
Lines 597 611 +14
Branches 45 52 +7
==========================================
+ Hits 564 578 +14
Misses 24 24
Partials 9 9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that lines starting with / happen randomly, e.g.
because of people pasting absolute paths into comment boxes. So now we
should ignore them instead of raising NotImplementedError like we used
to.
Switched to using a markdown parser to process text before searching
for /-commands, so we ignore /-commands inside blockquotes, fenced
code blocks, HTML comments, etc.
This is probably silly overkill, but I had fun writing it, so hey.