Modernize sniffio integration #124
Conversation
Use `sniffio.thread_local` to indicate which async library is running, instead of the deprecated `sniffio.current_async_library_cvar`. This allows us to remove a number of workarounds for the contextvar being inherited where it shouldn't be.
| @@ -56,7 +56,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| python: ['pypy-3.7', 'pypy-3.8', 'pypy-3.9', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12-dev', 'pypy-3.8-nightly', 'pypy-3.9-nightly'] | |||
| python: ['pypy-3.7', 'pypy-3.8', 'pypy-3.9', '3.7', '3.8', '3.9', '3.10', '3.11', 'pypy-3.8-nightly', 'pypy-3.9-nightly'] | |||
There was a problem hiding this comment.
| python: ['pypy-3.7', 'pypy-3.8', 'pypy-3.9', '3.7', '3.8', '3.9', '3.10', '3.11', 'pypy-3.8-nightly', 'pypy-3.9-nightly'] | |
| python: ['pypy-3.7', 'pypy-3.8', 'pypy-3.9', '3.7', '3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.8-nightly', 'pypy-3.9-nightly'] |
Maybe?
There was a problem hiding this comment.
I'm going to do another PR to drop 3.7 and add 3.12 support to CI and the setup.py trove classifiers. For now just wanted to do the minimal thing to get it to build. The error with 3.12-dev is an Ubuntu packaging thing unrelated to trio-asyncio.
There was a problem hiding this comment.
Yeah I suggested the change cause it looks like the step that fails only runs if the version ends with -dev (probably remnants of setup-python not supporting dev versions?). But totally fair to move it to another PR.
|
Generally, it might be nice if sniffio had a warning if both methods of setting async library name are set? Not sure and tbh I should just make an issue on that repo, just running this by you first! (it negates possible perf improvements, though it could be behind an |
Trio and trio-asyncio are the only libraries that actually integrate with sniffio, so now that they're both updated I'm not sure it's worth the churn. |
Use
sniffio.thread_localto indicate which async library is running, instead of the deprecatedsniffio.current_async_library_cvar. This allows us to remove a number of workarounds for the contextvar being inherited where it shouldn't be, and is also necessary to interoperate with Trio 0.23 which uses the thread-local.Fixes #123.