Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.8.0 #26

Merged
merged 23 commits into from
Aug 3, 2018
Merged

Release 0.8.0 #26

merged 23 commits into from
Aug 3, 2018

Conversation

smurfix
Copy link
Collaborator

@smurfix smurfix commented Aug 3, 2018

Yay

smurfix and others added 18 commits July 26, 2018 13:40
from within Trio but without an active loop
the code is still there, for now, but …
The new tests are probably going to fail horribly because of gh-23
With Python 3.7, the C runtime caches get_running_loop_policy()
so we can no longer monkey-patch it effectively.

On the other hand, we really want per-thread loop policies.

Thus, the Trio loop policy is (again) installed unconditionally.
`get_running_loop_policy()` now does this:
* when Trio is running: return itself.
* otherwise: return a per-thread policy, or the original loop policy.

* `set_running_loop_policy()` refuses to install a TrioPolicy,
  and otherwise installs into a per-thread variable.

All methods of `TrioPolicy` now unconditionally access the current
task's loop (as per contextvar) if they're running within Trio.
Otherwise they defer to the per-thread loop policy.
_ipaddr_info is extended … sometimes.
SIGHUP is not in valid_signals ?!?
@smurfix smurfix closed this Aug 3, 2018
@smurfix smurfix deleted the fix1 branch August 3, 2018 11:54
@smurfix smurfix reopened this Aug 3, 2018
@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #26 into master will decrease coverage by 2.59%.
The diff coverage is 69.38%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #26     +/-   ##
=========================================
- Coverage   74.95%   72.35%   -2.6%     
=========================================
  Files          11       11             
  Lines        1054     1096     +42     
  Branches      139      146      +7     
=========================================
+ Hits          790      793      +3     
- Misses        220      260     +40     
+ Partials       44       43      -1
Impacted Files Coverage Δ
trio_asyncio/_version.py 100% <100%> (ø) ⬆️
trio_asyncio/base.py 84.74% <50%> (-1.29%) ⬇️
trio_asyncio/loop.py 60.1% <69.56%> (-6.79%) ⬇️
trio_asyncio/handles.py 82.1% <0%> (-4.22%) ⬇️
trio_asyncio/sync.py 81.1% <0%> (-3.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c9c54...4cc04aa. Read the comment docs.

@smurfix smurfix merged commit 84bfc2e into master Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants