Allow multiple calls to loop.stop #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling loop.stop and then immediately proceeding to exit the `open_loop`'s context (without hitting any checkpoints) causes the program to hang forever Fix by reusing the same `waiter` event across multiple calls to `stop` Fixes python-trio#58
|
@smurfix I know you suggested a mention in the docs. It looked reasonable to fix, so I had a go at it. If you'd prefer just a doc fix, no worries, I can just do that! |
|
Looks good. Can you add a newsfragment? |
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 73.33% 73.55% +0.22%
==========================================
Files 11 11
Lines 1264 1267 +3
Branches 165 166 +1
==========================================
+ Hits 927 932 +5
+ Misses 282 281 -1
+ Partials 55 54 -1
|
|
added to "next" branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling loop.stop and then immediately proceeding to exit the
open_loop's context (without hitting any checkpoints) causes theprogram to hang forever
Fix by reusing the same
waiterevent across multiple calls tostopFixes #58