Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using trustme for testing TLS certs #244

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jul 24, 2017

Don't merge this yet - it needs
python-trio/trustme#4
to be merged and released first.

I guess this won't be a problem b/c all the tests are going to fail
mightily until that happens. But I figured I'd get put the branch up
in any case so it doesn't get misplaced.

@njsmith
Copy link
Member Author

njsmith commented Aug 2, 2017

New trustme is released; let's see how this goes.

@njsmith
Copy link
Member Author

njsmith commented Aug 3, 2017

Ok, did another release of trustme, now actually testing on Windows. Maybe this will work better.

@codecov
Copy link

codecov bot commented Aug 3, 2017

Codecov Report

Merging #244 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   99.11%   99.14%   +0.02%     
==========================================
  Files          63       63              
  Lines        8739     8850     +111     
  Branches      627      633       +6     
==========================================
+ Hits         8662     8774     +112     
  Misses         61       61              
+ Partials       16       15       -1
Impacted Files Coverage Δ
trio/tests/test_ssl.py 100% <100%> (ø) ⬆️
trio/_core/_local.py 100% <0%> (ø) ⬆️
trio/tests/test_socket.py 100% <0%> (ø) ⬆️
trio/abc.py 100% <0%> (ø) ⬆️
trio/_core/tests/test_local.py 100% <0%> (ø) ⬆️
trio/socket.py 100% <0%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8a564...c67d2fb. Read the comment docs.

@njsmith njsmith merged commit 1f52e76 into python-trio:master Aug 3, 2017
@njsmith njsmith deleted the use-trustme branch August 3, 2017 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant