Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change strict_exception_groups default to True #2886

Merged
merged 30 commits into from
Jan 22, 2024
Merged

change strict_exception_groups default to True #2886

merged 30 commits into from
Jan 22, 2024

Commits on Nov 24, 2023

  1. change strict_exception_groups default to True

    @jakkdl
    jakkdl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    cfc0755 View commit details
    Browse the repository at this point in the history

  2. get rid of the last vestiges of _assert_raises

    @jakkdl
    jakkdl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    84fb527 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Merge remote-tracking branch 'origin/master' into remove_multierror

    @jakkdl
    jakkdl committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c4548bd View commit details
    Browse the repository at this point in the history

  2. fix check for @Final

    @jakkdl
    jakkdl committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2437d1e View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. add typeguard to ExpectedExceptionGroup.matches

    @jakkdl
    jakkdl committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    dcadc87 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. update comments/tests where I was confused about lack of ExceptionGro… 

    …ups, and noted by reviewers
    @jakkdl
    jakkdl committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    a39732f View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Merge branch 'master' into remove_multierror

    @CoolCat467
    CoolCat467 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    669c345 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks

    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    f7e0b8f View commit details
    Browse the repository at this point in the history

  3. Fix ruff issues

    @CoolCat467
    CoolCat467 committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    38f47a5 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Merge remote-tracking branch 'origin/master' into remove_multierror 

    and fix various errors, also disabling PT012.
    @jakkdl
    jakkdl committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    d455a45 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2024

  1. Merge remote-tracking branch 'origin/master' into remove_multierror 

    Note that this has *both* RaisesGroup and ExpectedExceptionGroup
    @jakkdl
    jakkdl committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    4232be2 View commit details
    Browse the repository at this point in the history

  2. replace all instances of ExpectedExceptionGroup with RaisesGroup

    @jakkdl
    jakkdl committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    5caf49f View commit details
    Browse the repository at this point in the history

  3. gone through the whole PR and cleaned it up

    @jakkdl
    jakkdl committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    f50386c View commit details
    Browse the repository at this point in the history

  4. fix tests: remove stray pytest import

    @jakkdl
    jakkdl committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    5acae48 View commit details
    Browse the repository at this point in the history

  5. fix coverage

    @jakkdl
    jakkdl committed Jan 7, 2024
    Configuration menu
    Copy the full SHA
    a33bea6 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. proposed fix for run_process raising exceptiongroup

    @jakkdl
    jakkdl committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    295e5af View commit details
    Browse the repository at this point in the history

  2. add test for TrioInternalError from run_process

    @jakkdl
    jakkdl committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    0089248 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Zac Hatfield-Dodds <zac.hatfield.dodds@gmail.com>
    @jakkdl @Zac-HD
    jakkdl and Zac-HD committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    26a9c62 View commit details
    Browse the repository at this point in the history

  4. rephrase newsfragment, and add rst cross-references

    @jakkdl
    jakkdl committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a93a185 View commit details
    Browse the repository at this point in the history

  5. update docstrings

    @jakkdl
    jakkdl committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b3d5aa3 View commit details
    Browse the repository at this point in the history

  6. add comment with TODO about rewriting strict_exception_groups section

    @jakkdl
    jakkdl committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    c00a05f View commit details
    Browse the repository at this point in the history

  7. parametrize run/nursery strictness tests

    @jakkdl
    jakkdl committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4b393ed View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. revert reraising exceptiongroup as a TrioInternalError, mention that … 

    …it may raise exceptiongroup in docstring
    @jakkdl
    jakkdl committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e64d508 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into remove_multierror

    @jakkdl
    jakkdl committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    0547313 View commit details
    Browse the repository at this point in the history

  3. fix test_run_process_internal_error, add test_bad_deliver_cancel

    @jakkdl
    jakkdl committed Jan 11, 2024
    2 Configuration menu
    Copy the full SHA
    22e4765 View commit details
    Browse the repository at this point in the history

  4. fix docstring

    @jakkdl
    jakkdl committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    79754b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Merge branch 'master' into remove_multierror

    @CoolCat467
    CoolCat467 committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    506e211 View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2024

  1. revert accidental removal of empty line

    @jakkdl
    jakkdl committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    ea48cf0 View commit details
    Browse the repository at this point in the history

  2. Add a bunch of words to the newsfragment

    @jakkdl
    jakkdl committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    3f519f8 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into remove_multierror

    @jakkdl
    jakkdl committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    0b45ec9 View commit details
    Browse the repository at this point in the history