Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #2946

Merged
merged 4 commits into from
Feb 11, 2024
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Feb 5, 2024

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.1.14 → v0.2.0](astral-sh/ruff-pre-commit@v0.1.14...v0.2.0)
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70c8b76) 99.44% compared to head (2aa5065) 99.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2946      +/-   ##
==========================================
+ Coverage   99.44%   99.64%   +0.19%     
==========================================
  Files         117      117              
  Lines       17564    17564              
  Branches     3166     3166              
==========================================
+ Hits        17467    17502      +35     
+ Misses         79       43      -36     
- Partials       18       19       +1     

see 9 files with indirect coverage changes

@CoolCat467 CoolCat467 self-assigned this Feb 5, 2024
@CoolCat467 CoolCat467 added the dependencies Pull requests that update a dependency file label Feb 5, 2024
@CoolCat467
Copy link
Contributor

Pretty good, but I think we might need to make a few minor config changes: https://astral.sh/blog/ruff-v0.2.0

@CoolCat467
Copy link
Contributor

CoolCat467 commented Feb 5, 2024

Oh that's cool, a few of the TRIO rules are out of preview

@CoolCat467
Copy link
Contributor

CoolCat467 commented Feb 6, 2024

Getting some kind of wacky pypy 3.10 failures: TypeError: int() not supported on cdata 'size_t[1]', pretty sure it isn't related to updating ruff though

@TeamSpen210
Copy link
Contributor

Probably should enable the TRIO rules? Maybe in a separate PR.

@jakkdl
Copy link
Member

jakkdl commented Feb 6, 2024

Getting some kind of wacky pypy 3.10 failures: TypeError: int() not supported on cdata 'size_t[1]', pretty sure it isn't related to updating ruff though

it's specifically pypy 3.10-nightly, so probably time to fix

Removing runs:

  • Don't run PyPy nightlies that aren't 3.11

as mentioned in #2885

Copy link
Contributor

@A5rocks A5rocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reran one of the pypy-3.10-nightly jobs here: https://github.com/python-trio/trio/actions/runs/7792993619/job/21432501263?pr=2946

It didn't error this time. Probably just a bad nightly version.

@CoolCat467 CoolCat467 closed this Feb 10, 2024
@CoolCat467 CoolCat467 reopened this Feb 10, 2024
@CoolCat467 CoolCat467 merged commit bd19635 into master Feb 11, 2024
79 of 82 checks passed
@CoolCat467 CoolCat467 deleted the pre-commit-ci-update-config branch February 11, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants