Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docstring for from_thread_run to reflect how to get trio token #3001

Merged
merged 3 commits into from
May 18, 2024

Conversation

oakal510
Copy link
Contributor

@oakal510 oakal510 commented May 18, 2024

Added a documentation fix for the following issue: fixes #1439.

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (6f62575) to head (23b2c87).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3001   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         120      120           
  Lines       17798    17798           
  Branches     3198     3198           
=======================================
  Hits        17733    17733           
  Misses         46       46           
  Partials       19       19           
Files Coverage Δ
src/trio/_threads.py 100.00% <ø> (ø)

@oakal510 oakal510 closed this May 18, 2024
@oakal510 oakal510 reopened this May 18, 2024
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @oakal510!

@Zac-HD Zac-HD merged commit 60b5804 into python-trio:master May 18, 2024
28 checks passed
@trio-bot
Copy link

trio-bot bot commented May 18, 2024

Hey @oakal510, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to get "trio token" for trio.to_thread.run_sync?
2 participants