Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cert expiration dates to avoid Y2038 problem #42

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

njsmith
Copy link
Member

@njsmith njsmith commented Jan 9, 2019

Fixes: gh-41

@njsmith
Copy link
Member Author

njsmith commented Jan 9, 2019

I'd like to have a test for this, but it seems difficult, since I guess I need a 32-bit linux distro or something... anyone have suggestions?

@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #42   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         328    328           
  Branches       21     21           
=====================================
  Hits          328    328
Flag Coverage Δ
#linux 100% <ø> (ø) ⬆️
#windows 100% <ø> (ø) ⬆️
Impacted Files Coverage Δ
trustme/__init__.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb7ef8b...e24d10f. Read the comment docs.

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of an useful test either!

@webknjaz
Copy link
Member

@njsmith we're hitting the error under manylinux1 docker image, 32-bit version which you can spawn in Travis CI. Or even better: you can run that from GitHub Actions (didn't test it yet).

@webknjaz
Copy link
Member

smth small like this should also work https://hub.docker.com/r/i386/ubuntu/tags

@njsmith
Copy link
Member Author

njsmith commented Jan 22, 2019

I have failed to find the energy to fight with docker on this one, so let's not hold it up any longer.

@njsmith njsmith merged commit 85443fc into python-trio:master Jan 22, 2019
@njsmith njsmith deleted the y2038-fix branch January 22, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants