Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ECDSA keys and use them by default #563

Merged
merged 6 commits into from
Apr 19, 2023

Commits on Mar 9, 2023

  1. Implement ECDSA keys and use them by default

    ECDSA keys can be generated an order of magnitude faster than RSA keys.
    This commit adds an implementation for ECDSA, and adds parameters to
    CA.__init__, CA.issue_certificate and CA.create_child_ca. The default is
    ECDSA, given that OpenSSL and browsers support this for at least 10
    years. This also adds an option to the cli to switch between RSA and ECDSA.
    
    The basic test and the SSL server test have been parametrized over both
    types of keys. This ensures that RSA support is not accidentally broken,
    while keeping most of the tests fast.
    VincentVanlaer committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8ad0cfa View commit details
    Browse the repository at this point in the history
  2. Drop types-cryptography in lint

    Cryptography provides types since version 3.4.4 and the relevant
    interfaces have been typed since version 35.0.0
    VincentVanlaer committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    ef47380 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Remove check on keytype when loading from file

    This would be a breaking change and it makes codecov happier. This could
    be reintroduced in the future using a larger set of allowed keys, for
    example using
    cryptography.hazmat.primitives.asymmetric.types.CertificatePublicKeyTypes.
    VincentVanlaer committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    f0df8bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    27604f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Add no cover else branch to _generate_key

    There doesn't seem to be a way to tell coverage to ignore the the case
    when nothing matches in a if-elif group.
    VincentVanlaer committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    9d89683 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Configuration menu
    Copy the full SHA
    f74a9b6 View commit details
    Browse the repository at this point in the history