Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with PUT api requests #414

Closed
snail-coupe opened this issue Jun 30, 2020 · 0 comments
Closed

Issues with PUT api requests #414

snail-coupe opened this issue Jun 30, 2020 · 0 comments

Comments

@snail-coupe
Copy link
Contributor

I'm trying to use the twitter.direct_messages.welcome_messages.update end point, however this uses the PUT method (https://developer.twitter.com/en/docs/direct-messages/welcome-messages/api-reference/update-welcome-message) and there appeared to be various issues with both the signature and the request because:

  • urllib.request doesn't get passed the method so assumes it is a POST request breaking the request and the signature.
  • the required id parameter doesn't get passed as part of the url as the library assumes all required parameters are within the body. (This is an issue for the two PUT method API calls, I don't know if it is a bigger issue)

In diagnosing this I have a fix which I resolved this for my limited use case. I've forked the project and can submit a pull request, although appreciate I've not looked at any coding standards or similar so it may need additional work.

RouxRC pushed a commit that referenced this issue Feb 2, 2021
RouxRC pushed a commit that referenced this issue May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants