Use buffer except for 2.6 #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not noticeable to test it each time. (Please review this logic.) Hence, I've shortened the code to just the lines necessary to maintain Python v2.6 compatibility.
… tuple rank comparison.
|
As the system version does not change during execution, I've moved those tests out of the chunk processing in favor of a boolean, |
RouxRC
added a commit
to RouxRC/twitter
that referenced
this pull request
Feb 16, 2014
sixohsix
added a commit
that referenced
this pull request
Feb 17, 2014
Fix streams timeout & hangup behavior + ensure python2.6 compat Here are the changes to fix the misbehavior of the timeout in case of low tweets by catching Twitter's keep-alive heartbeat signals thanks to the select.select originally added in #178 and still problematic as pointed out by @ksecrist in #202 I also generalized the hangup to all cases since there is no reason to stay in infinite loop after a hangup in non-blocking mode. And to make things easier and avoid merging issues, I adapted the refacto and fixed python2.6 compatibility from @adonoho's #201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the patch. Move the version test into the chunk processing. As it is probably i/o dominated, this should not be a performance issue. Experienced Pythonistas, please review this supposition.