Naming/ordering of keys/secrets in examples (in readme & api.py) is off #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the basic examples, the order of consumer secret & consumer key doesn't match what actually works. Fixed.
changed naming and ordering of consumer key/secret and token/token secret in examples so that they are in correct order
Corrected naming and order of token, token secret, consumer key & consumer secret to match naming & order that actually works
RouxRC
approved these changes
Sep 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a bit longer than it should have to use this library today because the basic example code (in the readme & as generated from api.py) has the consumer secret & consumer key in the wrong order.
This is a pull request to change that order in the docs, and to rename the example vars to match the ones in the oauth examples further down in the documentation.
Thanks!