New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using a ssl context object to avoid deprecation warnings in py3 #451
Conversation
Please could you add comments to say which bit is for Python 2 and which for 3? That will make it easier to clean up the code when the time comes. |
Pull Request Test Coverage Report for Build 3052768982
💛 - Coveralls |
The code I wrote works the same in py2 and py3 as far as I know so nothing to clean up when the time comes (to kill py2 I suppose?). It's just that the earlier PR was triggering deprecation warning on py >= 3.6. Now it does not. |
I'm the one who sollicitated the PR to @Yomguithereal following the previous one. |
I think it's a good idea to test at least one on Windows and macOS. We don't necessarily need to add them to the full matrix to get the benefit. We currently have: "2.7",
"3.6",
"3.7",
"3.8",
"3.9",
"3.10",
"3.11-dev",
"pypy2.7", We could switch out one of these middle versions to run on Windows instead of Ubuntu, and another to run on macOS. In fact, we could remove some of those middle Ubuntu ones anyway, some projects only test on lower and upper bounds. So for example: "2.7",
"3.6",
- "3.7",
- "3.8",
- "3.9",
"3.10",
"3.11-dev",
"pypy2.7", Also Python 3.6 has been EOL since last year (2021-12-23) so that could be dropped. (Plus I still recommend EOL 2.7 being dropped (2020-01-01) ;) |
I like the idea to test some versions with mac and windows, for instance we could remove 3.7, and run 3.8 under windows and 3.9 under macOS ? |
Sounds good, I'll create a PR. Fine with me if you'd like to keep 2.7 longer. How about 3.6? |
Ha I misread you, then let's rather say drop 3.6, keep 3.7 on ubuntu, 3.8 windows and 3.9 mac? |
Please see PR #453 |
No description provided.