Migrate to the last pylint

python-useful-helpers · May 6, 2020 · 85843cf · 85843cf
1 parent 4234ff8
commit 85843cf
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -41,7 +41,7 @@ jobs:
       install:
         - *upgrade_python_toolset
         - *install_deps
-        - pip install --upgrade "pylint!=2.5.0" isort[pyproject,requirements]
+        - pip install --upgrade "pylint>=2.5.2" isort[pyproject,requirements]
       script:
         - python setup.py develop -v clean
         - python setup.py --version clean

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -44,7 +44,7 @@ jobs:
           python -m pip install --upgrade pip
           pip install -U setuptools virtualenv
           pip install -r CI_REQUIREMENTS.txt
-          pip install -U pylint!=2.5.0 pylint_junit isort[pyproject,requirements]
+          pip install -U pylint>=2.5.2 pylint_junit isort[pyproject,requirements]
         displayName: 'Install dependencies'
 
       - script: |

diff --git a/exec_helpers/_ssh_base.py b/exec_helpers/_ssh_base.py
@@ -533,7 +533,7 @@ def __get_client(self) -> paramiko.SSHClient:
             if config.proxycommand:
                 raise ValueError(f"ProxyCommand found in connection chain after first host reached!\n{config}")
 
-            raise RuntimeError(f"Unexpected state: Final host by configuration, but requested host is not reached")
+            raise RuntimeError("Unexpected state: Final host by configuration, but requested host is not reached")
         return last_ssh_client
 
     def __connect_sftp(self) -> None:

diff --git a/exec_helpers/async_api/api.py b/exec_helpers/async_api/api.py
@@ -121,7 +121,7 @@ def chroot(self, path: "typing.Union[str, pathlib.Path, None]") -> "typing.Conte
         return _ChRootContext(conn=self, path=path)
 
     @abc.abstractmethod
-    async def _exec_command(  # type: ignore
+    async def _exec_command(  # type: ignore  # pylint: disable=invalid-overridden-method
         self,
         command: str,
         async_result: api.ExecuteAsyncResult,
@@ -156,7 +156,7 @@ async def _exec_command(  # type: ignore
         """
 
     @abc.abstractmethod
-    async def _execute_async(  # type: ignore
+    async def _execute_async(  # type: ignore  # pylint: disable=invalid-overridden-method
         self,
         command: str,
         *,
@@ -194,7 +194,7 @@ async def _execute_async(  # type: ignore
         :raises OSError: impossible to process STDIN
         """
 
-    async def execute(  # type: ignore
+    async def execute(  # type: ignore  # pylint: disable=invalid-overridden-method
         self,
         command: CommandT,
         verbose: bool = False,
@@ -257,7 +257,7 @@ async def execute(  # type: ignore
         self.logger.log(level=log_level, msg=f"Command {result.cmd!r} exit code: {result.exit_code!s}")
         return result
 
-    async def __call__(  # type: ignore
+    async def __call__(  # type: ignore  # pylint: disable=invalid-overridden-method
         self,
         command: CommandT,
         verbose: bool = False,
@@ -305,7 +305,7 @@ async def __call__(  # type: ignore
             **kwargs,
         )
 
-    async def check_call(  # type: ignore
+    async def check_call(  # type: ignore  # pylint: disable=invalid-overridden-method
         self,
         command: CommandT,
         verbose: bool = False,
@@ -377,7 +377,7 @@ async def check_call(  # type: ignore
                 raise exception_class(result=result, expected=expected_codes)
         return result
 
-    async def check_stderr(  # type: ignore
+    async def check_stderr(  # type: ignore  # pylint: disable=invalid-overridden-method
         self,
         command: CommandT,
         verbose: bool = False,

diff --git a/exec_helpers/async_api/exec_result.py b/exec_helpers/async_api/exec_result.py
@@ -36,7 +36,7 @@ class ExecResult(exec_result.ExecResult):
     __slots__ = ()
 
     @staticmethod
-    async def _poll_stream(  # type: ignore
+    async def _poll_stream(  # type: ignore  # pylint: disable=invalid-overridden-method
         src: _StreamT, log: "typing.Optional[logging.Logger]" = None, verbose: bool = False
     ) -> "typing.List[bytes]":
         """Stream poll helper.
@@ -57,7 +57,7 @@ async def _poll_stream(  # type: ignore
                     )
         return dst
 
-    async def read_stdout(  # type: ignore
+    async def read_stdout(  # type: ignore  # pylint: disable=invalid-overridden-method
         self,
         src: "typing.Optional[_StreamT]" = None,
         log: "typing.Optional[logging.Logger]" = None,
@@ -84,7 +84,7 @@ async def read_stdout(  # type: ignore
             self._stdout_str = self._stdout_brief = None
             self._stdout += tuple(await self._poll_stream(src, log, verbose))
 
-    async def read_stderr(  # type: ignore
+    async def read_stderr(  # type: ignore  # pylint: disable=invalid-overridden-method
         self,
         src: "typing.Optional[_StreamT]" = None,
         log: "typing.Optional[logging.Logger]" = None,

diff --git a/tox.ini b/tox.ini
@@ -53,7 +53,7 @@ commands = pip install ./ -vvv -U
 [testenv:pylint]
 usedevelop = True
 deps =
-  pylint!=2.5.0
+  pylint>=2.5.2
   isort[pyproject,requirements]
   -r{toxinidir}/CI_REQUIREMENTS.txt
 commands =